Merge pull request #4855 from cagdas001/fix-4765

luizrrodrigues · web-flow · commit 97e3f1a45566 · 2020-09-03T21:06:35.000-03:00
fix(challenge-detail): condition for showing thrive articles
diff --git a/src/shared/containers/challenge-detail/index.jsx b/src/shared/containers/challenge-detail/index.jsx
@@ -244,7 +244,7 @@ class ChallengeDetailPageContainer extends React.Component {
     }
 
     const { track } = nextProps.challenge;
-    if (track === COMPETITION_TRACKS.DESIGN && thriveArticles.length === 0) {
+    if (track !== COMPETITION_TRACKS.DESIGN && thriveArticles.length === 0) {
       // filter all tags with value 'Other'
       const tags = _.filter(nextProps.challenge.tags, tag => tag !== 'Other');
       if (tags.length > 0) {

Original file line number	Diff line number	Diff line change
`@@ -244,7 +244,7 @@ class ChallengeDetailPageContainer extends React.Component {`
`244`	`244`	`}`
`245`	`245`
`246`	`246`	`const { track } = nextProps.challenge;`
`247`		`- if (track === COMPETITION_TRACKS.DESIGN && thriveArticles.length === 0) {`
	`247`	`+ if (track !== COMPETITION_TRACKS.DESIGN && thriveArticles.length === 0) {`
`248`	`248`	`// filter all tags with value 'Other'`
`249`	`249`	`const tags = _.filter(nextProps.challenge.tags, tag => tag !== 'Other');`
`250`	`250`	`if (tags.length > 0) {`