Merge pull request #5150 from topcoder-platform/bug-bash

Smoke Testing 2020-11-03 - First2Bash

Author: luizrrodrigues

.circleci/config.yml

@@ -245,7 +245,7 @@ workflows:
           filters:
             branches:
               only:
-                - listing-develop-sync
+                - develop
       # This is beta env for production soft releases
       - "build-prod-beta":
           context : org-global

__tests__/shared/components/Dashboard/SRM/__snapshots__/index.jsx.snap

@@ -49,7 +49,7 @@ exports[`Matches shallow shapshot 1`] = `
           </a>
           <a
             className="tc-btn tc-btn-s tc-btn-wide tc-btn-ghost src-shared-components-Dashboard-SRM-___styles__tc-btn___3no83"
-            href="https://www.topcoder-dev.com/member-onboarding/learning-practicing-skills/"
+            href="https://www.topcoder-dev.com/thrive/articles/How%20To%20Compete%20in%20SRMs"
           >
             Learn More
           </a>

__tests__/shared/components/__snapshots__/TopcoderFooter.jsx.snap

@@ -106,7 +106,7 @@ exports[`Matches shallow shapshot 1`] = `
             className="src-shared-components-TopcoderFooter-___style__link___3-nzm"
           >
             <a
-              href="https://www.topcoder-dev.com/thrive/tracks?track=Data%20Science"
+              href="https://www.topcoder-dev.com/thrive/tracks?track=Data%20Science&tax="
             >
               Data Science
             </a>
@@ -115,7 +115,7 @@ exports[`Matches shallow shapshot 1`] = `
             className="src-shared-components-TopcoderFooter-___style__link___3-nzm"
           >
             <a
-              href="https://www.topcoder-dev.com/thrive/tracks?track=Design"
+              href="https://www.topcoder-dev.com/thrive/tracks?track=Design&tax="
             >
               Design
             </a>
@@ -124,7 +124,7 @@ exports[`Matches shallow shapshot 1`] = `
             className="src-shared-components-TopcoderFooter-___style__link___3-nzm"
           >
             <a
-              href="https://www.topcoder-dev.com/thrive/tracks?track=Development"
+              href="https://www.topcoder-dev.com/thrive/tracks?track=Development&tax="
             >
               Development
             </a>
@@ -133,7 +133,7 @@ exports[`Matches shallow shapshot 1`] = `
             className="src-shared-components-TopcoderFooter-___style__link___3-nzm"
           >
             <a
-              href="https://www.topcoder-dev.com/thrive/tracks?track=QA"
+              href="https://www.topcoder-dev.com/thrive/tracks?track=QA&tax="
             >
               QA
             </a>

__tests__/shared/components/challenge-listing/Sidebar/__snapshots__/index.jsx.snap

@@ -16,7 +16,7 @@ exports[`Matches shallow shapshot 1`] = `
     />
   </div>
   <Footer
-    hideTcLinksInFooter={false}
+    hideTcLinksInFooter={true}
   />
 </div>
 `;
@@ -37,7 +37,7 @@ exports[`Matches shallow shapshot 2`] = `
     />
   </div>
   <Footer
-    hideTcLinksInFooter={false}
+    hideTcLinksInFooter={true}
   />
 </div>
 `;

src/shared/components/Dashboard/SRM/index.jsx

@@ -35,7 +35,7 @@ const SRM = (props) => {
               <a href={`${config.URL.COMMUNITY}/tc?module=ProblemArchive`} className="tc-btn tc-btn-s tc-btn-wide tc-btn-ghost" styleName="tc-btn">
                 Problem Archive
               </a>
-              <a href={`${config.URL.BASE}/member-onboarding/learning-practicing-skills/`} className="tc-btn tc-btn-s tc-btn-wide tc-btn-ghost" styleName="tc-btn">
+              <a href={`${config.URL.BASE}/thrive/articles/How%20To%20Compete%20in%20SRMs`} className="tc-btn tc-btn-s tc-btn-wide tc-btn-ghost" styleName="tc-btn">
                 Learn More
               </a>
             </div>

src/shared/components/TopcoderFooter/index.jsx

@@ -58,10 +58,10 @@ export default function TopcoderFooter() {
             <div styleName="sep-line" />
             <ul styleName="navi-col-links">
               <Link to={`${base}/thrive/tracks?track=Competitive%20Programming`}>Competitive Programming</Link>
-              <Link to={`${base}/thrive/tracks?track=Data%20Science`}>Data Science</Link>
-              <Link to={`${base}/thrive/tracks?track=Design`}>Design</Link>
-              <Link to={`${base}/thrive/tracks?track=Development`}>Development</Link>
-              <Link to={`${base}/thrive/tracks?track=QA`}>QA</Link>
+              <Link to={`${base}/thrive/tracks?track=Data%20Science&tax=`}>Data Science</Link>
+              <Link to={`${base}/thrive/tracks?track=Design&tax=`}>Design</Link>
+              <Link to={`${base}/thrive/tracks?track=Development&tax=`}>Development</Link>
+              <Link to={`${base}/thrive/tracks?track=QA&tax=`}>QA</Link>
             </ul>
           </div>
           <div styleName="navi-col">

src/shared/components/challenge-detail/Header/DeadlinesPanel/Card/index.jsx

@@ -10,6 +10,7 @@ import './style.scss';
 
 /* Date/time format to use in the card. */
 const FORMAT = 'MMM DD, HH:mm';
+const FORMAT_YEAR = 'MMM DD YYYY, HH:mm';
 
 export default function Card({ past, time, title }) {
   const time2 = moment(time);
@@ -20,7 +21,7 @@ export default function Card({ past, time, title }) {
         {title}
       </p>
       <p styleName="date">
-        {time2.format(FORMAT)}
+        {time2.format(time2.year() !== moment().year() ? FORMAT_YEAR : FORMAT)}
       </p>
     </div>
   );

src/shared/components/challenge-listing/Filters/ChallengeFilters.jsx

@@ -7,6 +7,7 @@ import SwitchWithLabel from 'components/SwitchWithLabel';
 import { challenge as challengeUtils } from 'topcoder-react-lib';
 // import { COMPETITION_TRACKS as TRACKS } from 'utils/tc';
 import _ from 'lodash';
+import { BUCKETS } from 'utils/challenge-listing/buckets';
 
 // import localStorage from 'localStorage';
 import ChallengeSearchBar from './ChallengeSearchBar';
@@ -49,6 +50,7 @@ export default function ChallengeFilters({
   if (filterState.events && filterState.events.length) filterRulesCount += 1;
   if (filterState.tags && filterState.tags.length) filterRulesCount += 1;
   if (filterState.types && filterState.types.length) filterRulesCount += 1;
+  if (activeBucket === BUCKETS.ALL && filterState.status && filterState.status !== 'All') filterRulesCount += 1;
   if (filterState.endDateStart || filterState.startDateEnd) {
     filterRulesCount += 1;
   }

src/shared/components/challenge-listing/Filters/FiltersPanel/index.jsx

@@ -359,7 +359,7 @@ export default function FiltersPanel({
                   }}
                   options={['Active', 'Completed', 'All'].map(mapOps)}
                   simpleValue
-                  value={filterState.status || 'Active'}
+                  value={filterState.status || 'All'}
                 />
               </div>
             ) : null
@@ -433,6 +433,7 @@ export default function FiltersPanel({
               events: [],
               endDateStart: null,
               startDateEnd: null,
+              status: 'All',
             });
             selectCommunity(defaultCommunityId);
             setSearchText('');

src/shared/components/challenge-listing/Filters/FiltersPanel/style.scss

@@ -293,8 +293,11 @@ $panel-radius-4: $corner-radius * 2;
 
   .filter-row {
     display: flex;
+    flex-direction: row;
     align-items: center;
+    flex-wrap: wrap;
     margin-right: $panel-space-100 + 17;
+    width: auto;
 
     @include xs-to-md {
       display: block;
@@ -397,6 +400,7 @@ $panel-radius-4: $corner-radius * 2;
         z-index: 3;
       }
 
+      min-width: 206px;
       margin-right: $panel-space-30;
 
       :global(.Select-value) {
@@ -407,6 +411,17 @@ $panel-radius-4: $corner-radius * 2;
         color: $tc-gray-50;
         line-height: $panel-space-30 - 2;
       }
+
+      @media screen and (max-width: 1024px) {
+        width: 100%;
+        margin-top: 15px;
+      }
+
+      @media screen and (min-width: 1025px) and (max-width: 1346px) {
+        margin-top: 15px;
+
+        @include calc(width, '50% - 30px');
+      }
     }
   }
 }

src/shared/components/challenge-listing/Listing/Bucket/index.jsx

@@ -184,7 +184,7 @@ export default function Bucket({
       {placeholders}
       {
       // (expandable || loadMore) && (expandable || !keepPlaceholders) && !loading && !expanded ? (
-        (expanding || expandable || loadMore) && !loading && !expanded ? (
+        (expanding || expandable) && !loading && loadMore && (expandable ? expanded : !expanded) ? (
           <a
             // href={`${challengesUrl}?${bucketQuery}`}
             href={`${challengesUrl}`}

src/shared/components/challenge-listing/Listing/index.jsx

@@ -182,8 +182,7 @@ function Listing({
     );
   };
 
-  if (!expanding && (activeBucket !== BUCKETS.ALL)
-  && (activeBucket !== BUCKETS.SAVED_FILTER)) {
+  if ((activeBucket !== BUCKETS.SAVED_FILTER)) {
     return (
       <div styleName="challengeCardContainer">
         {getBucket(activeBucket, true)}
@@ -207,7 +206,8 @@ function Listing({
   // }
   const loading = loadingMyChallenges
     || loadingOpenForRegistrationChallenges
-    || loadingOnGoingChallenges;
+    || loadingOnGoingChallenges
+    || loadingAllChallenges;
   const placeholders = [];
   if (challenges.length > 0 || (activeBucket === BUCKETS.ALL && allChallenges.length > 0)) {
     return (

src/shared/components/challenge-listing/Sidebar/index.jsx

@@ -39,7 +39,7 @@ export default function SideBarFilters({
   // editSavedFiltersMode,
   // extraBucket,
   // filterState,
-  hideTcLinksInFooter,
+  // hideTcLinksInFooter,
   isAuth,
   // resetFilterName,
   // savedFilters,
@@ -84,7 +84,7 @@ export default function SideBarFilters({
         />
         {/* )} */}
       </div>
-      <Footer hideTcLinksInFooter={hideTcLinksInFooter} />
+      <Footer hideTcLinksInFooter />
     </div>
   );
 }
@@ -94,7 +94,7 @@ SideBarFilters.defaultProps = {
   disabled: false,
   // dragState: {},
   // extraBucket: null,
-  hideTcLinksInFooter: false,
+  // hideTcLinksInFooter: false,
   isAuth: false,
   expanding: false,
 };
@@ -116,7 +116,7 @@ SideBarFilters.propTypes = {
   // editSavedFiltersMode: PT.bool.isRequired,
   // extraBucket: PT.string,
   // filterState: PT.shape().isRequired,
-  hideTcLinksInFooter: PT.bool,
+  // hideTcLinksInFooter: PT.bool,
   isAuth: PT.bool,
   // resetFilterName: PT.func.isRequired,
   // savedFilters: PT.arrayOf(PT.shape()).isRequired,

src/shared/containers/Dashboard/index.jsx

@@ -150,8 +150,7 @@ export class DashboardPageContainer extends React.Component {
     // if (now - tcBlogTimestamp > CACHE_MAX_AGE
     // && !tcBlogLoading) getTopcoderBlogFeed();
 
-    if (now - communitiesTimestamp < CACHE_MAX_AGE
-    && now - activeChallengesTimestamp < CACHE_MAX_AGE) {
+    if (now - communitiesTimestamp < CACHE_MAX_AGE) {
       updateCommunityStats(this.props);
     }
   }