Minor changes in Submission Management Page

- Online Review links removed on request from TonyJ.
- Downloading of submissions is enabled with use of legacy (Studio) API,
as the new APIs don't support it yet (https://github.com/topcoder-
platform/community-app/issues/9).
- Submission previews are shown using legacy (Studio) API
(#8)
- Delete submission icon is temporarly removed, as we don't have any API
to remove them yet (https://github.com/topcoder-platform/community-
app/issues/10).

Author: birdofpreyru

src/shared/actions/smp.js

@@ -2,13 +2,12 @@
  * My submissions management page specific actions.
  */
 
-/* global fetch */
-
 import _ from 'lodash';
 import 'isomorphic-fetch';
 import { createActions } from 'redux-actions';
 import { getApiV2, getApiV3 } from 'services/api';
 import config from 'utils/config';
+import { isClientSide } from 'utils/isomorphy';
 import logger from 'utils/logger';
 
 const apiV2 = (auth) => getApiV2(auth.tokenV2);
@@ -21,24 +20,14 @@ function deleteSubmission(challengeId, submissionId) {
   return Promise.resolve(submissionId);
 }
 
+/*  TODO: At this moment we don't need any special JS code to download
+    submissions: we get them from legacy Topcoder Studio API, which is
+    authenticated by cookies, and can be done with a simple <a> link in
+    the component. Soon we'll migrate to use the new TC API instead, and
+    then we'll decide, whether we need operate downloads in JS, or can we
+    just remove this action. */
 function downloadSubmission(tokens, type, submissionId) {
-  /*
-    TODO: This will work with legacy API once we pass the tcsso cookie
-    along with the request.
-  const url = `${config.STUDIO_URL}?module=DownloadSubmission&sbmid=${submissionId}&sbt=original`;
-  fetch(url, {
-    mode: 'no-cors',
-  });
-  */
-  const endpoint = `/${type}/download/${submissionId}?submissionType=original`;
-  return apiV2(tokens).get(endpoint).then(res =>
-    new Promise(resolve =>
-      res.json().then((json) => {
-        if (res.status !== 200) logger.error(json);
-        resolve(json);
-      }),
-    ),
-  );
+  _.noop(tokens, type, submissionId);
 }
 
 export default createActions({
@@ -48,5 +37,5 @@ export default createActions({
     CONFIRM_DELETE: _.identity,
     DELETE_SUBMISSION_DONE: deleteSubmission,
     DOWNLOAD_SUBMISSION: downloadSubmission,
-  }
+  },
 });

src/shared/components/SubmissionManagement/ScreeningDetails/index.jsx

@@ -84,9 +84,14 @@ export default function ScreeningDetails(props) {
     <div styleName="screening-details" >
       <div styleName="screening-details-head">
         <p styleName={`status-title ${setStatusInfo().classname}`}>{setStatusInfo().title}</p>
+        {/*
+          NOTE: TonyJ asked to remove the OR links from the page to keep
+          users within the new Topcoder site as much as we can. Not wiping
+          out the code just in case we decide to bring it back later.
         <a href={onlineReviewUrl} styleName="online-review-link">
           Online Review
         </a>
+        */}
       </div>
       <p>{setStatusInfo().message}</p>
       <div styleName="screening-warning">

src/shared/components/SubmissionManagement/Submission/index.jsx

@@ -12,6 +12,7 @@
  */
 
 import _ from 'lodash';
+import config from 'utils/config';
 import moment from 'moment';
 import React, { PropTypes as PT } from 'react';
 
@@ -39,7 +40,10 @@ export default function Submission(props) {
         <img
           alt="preview"
           styleName={type === 'design' ? 'design-img' : 'dev-img'}
-          src={submissionObject.preview||'http://placehold.it/90/a01230'}
+          src={
+            submissionObject.preview||
+            `${config.STUDIO_URL}?module=DownloadSubmission&sbmid=${submissionObject.submissionId}&sbt=tiny`
+          }
         />
       </td>
       <td styleName="id-col">{submissionObject.submissionId}</td>
@@ -55,13 +59,25 @@ export default function Submission(props) {
       </td>}
       <td>
         <div styleName="action-col">
+          <a href={`${config.STUDIO_URL}?module=DownloadSubmission&sbmid=${submissionObject.submissionId}&sbt=original`}>
+            <DownloadIcon />
+          </a>
+          { /*
+            TODO: At the moment we just fetch downloads from the legacy
+              Topcoder Studio API, and we don't need any JS code to this.
+              It may change soon, as we move to the new TC API for
+              downloads. Then we'll use this commented out code or
+              remove it for good.
           <button
             onClick={() => onDownload(submissionObject.submissionId)}
           ><DownloadIcon /></button>
+          */ }
+          {/* TODO: At the moment APIs don't support removal of
+            submissions, thus the icon is temporarly removed.
           <button
             styleName="delete-icon"
             onClick={() => onDelete(submissionObject.submissionId)}
-          ><DeleteIcon /></button>
+          ><DeleteIcon /></button> */}
           <button
             styleName={`expand-icon ${(showScreeningDetails ? 'expanded' : '')}`}
             onClick={() => onShowDetails(submissionObject.submissionId)}

src/shared/components/SubmissionManagement/Submission/styles.scss

@@ -97,6 +97,7 @@ $submission-space-50: $base-unit * 10;
 
     .expand-icon {
       transition: all 1.5s;
+      margin-left: 12px;
 
       &.expanded {
         transform: rotate(180deg);