Fix: correct counting of sub-community members

Author: birdofpreyru

src/shared/actions/stats.js

@@ -17,6 +17,7 @@ import { getService as getGroupService } from 'services/groups';
  *  related to private groups.
  * @return {Promise} Resolves to the loaded data.
  */
+/* TODO: This code should be moved to a dedicated service. */
 function getCommunityStats(community, challenges, token) {
   /* TODO: At the moment, this component loads challenge objects to calculate
    * the number of challenges and the total prize. Probably in future, we'll
@@ -33,13 +34,18 @@ function getCommunityStats(community, challenges, token) {
     },
   };
   if (community.groupIds && community.groupIds.length) {
-    /* TODO: Should be properly updated to count members from all groups
-     * without double-counting. */
-    return groupService.getMembers(community.groupIds[0])
-      .then((members) => {
-        result.stats.numMembers = members.length;
-        return result;
-      }).catch(() => result);
+    const members = new Set();
+    return Promise.all(
+      community.groupIds.map(id =>
+        groupService.getMembers(id)
+          .then(res => res.forEach((member) => {
+            if (member.membershipType === 'user') members.add(member);
+          })).catch(),
+      ),
+    ).then(() => {
+      result.stats.numMembers = members.size;
+      return result;
+    });
   }
   return result;
 }

src/shared/reducers/groups.js

@@ -19,11 +19,7 @@
 
 import _ from 'lodash';
 import actions from 'actions/groups';
-import { getService as getCommunitiesService } from 'services/communities';
 import { handleActions } from 'redux-actions';
-import { getCommunityId } from 'routes/subdomains';
-import { toFSA } from 'utils/redux';
-import { getAuthTokens } from 'utils/tc';
 
 /**
  * Private. Given two user group maps, it adds to "dst" the root group from
@@ -102,50 +98,13 @@ function create(state) {
   }));
 }
 
-/**
- * Loads into the state detailed information on the groups related to the
- * specified community.
- *
- * NOTE: This function is intended for the internal use only, it modifies
- * "state" argument!
- *
- * @param {String} communityId
- * @param {String} tokenV3
- * @param {Object} state
- * @return {Promise} Resolves to the resulting state.
- */
-function loadCommunityGroups(communityId, tokenV3, state) {
-  let res = _.defaults(state, { groups: {}, loading: {} });
-  return getCommunitiesService(tokenV3).getMetadata(communityId).then((data) => {
-    let ids = data.authorizedGroupIds || [];
-    if (data.groupIds) ids = ids.concat(data.groupIds);
-    res = onGetGroupsInit(res, { payload: ids });
-    return toFSA(actions.groups.getGroupsDone(ids, tokenV3))
-      .then((action) => { res = onGetGroupsDone(res, action); })
-      .then(() => res);
-  });
-}
-
 /**
  * Reducer factory.
  * @param {Object} req Optional. ExpressJS HTTP request. If provided, the
  *  intial state of the reducer will be tailored to the request.
  * @return {Promise} Resolves to the reducer.
  */
-export function factory(req) {
-  if (req) {
-    /* For any location within any TC community we should load detailed
-     * information about any related user groups. */
-    let communityId = getCommunityId(req.subdomains);
-    if (!communityId && req.url.startsWith('/community')) {
-      communityId = req.url.split('/')[2];
-    }
-    if (communityId) {
-      const tokenV3 = getAuthTokens(req).tokenV3;
-      return loadCommunityGroups(communityId, tokenV3, {})
-        .then(res => create(res));
-    }
-  }
+export function factory(/* req */) {
   return Promise.resolve(create());
 }