Skip to content

Commit 7a7bb38

Browse files
committed
incorporate feedback
1 parent 17a75a5 commit 7a7bb38

File tree

2 files changed

+33
-30
lines changed

2 files changed

+33
-30
lines changed

src/shared/components/Settings/Profile/Skills/index.jsx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -507,13 +507,13 @@ export default class Skills extends ConsentComponent {
507507
<div styleName="hidden-indicator" />
508508
{ imageExist(`id-${skill.id}.svg`) ? getImage(`id-${skill.id}.svg`) : <FallbackIcon /> }
509509
</div>
510-
<div styleName="name-wrapper">
511-
<div styleName="name">
512-
{_.truncate(skill.name, { length: 18, separator: ' ' })}
513-
</div>
514-
{_.includes(skill.sources, 'CHALLENGE') && <div styleName="verified-badge"><VerifiedBadgeIcon /></div> }
515-
</div>
516510
</a>
511+
<div styleName="name-wrapper">
512+
<div styleName="name">
513+
{_.truncate(skill.name, { length: 18, separator: ' ' })}
514+
</div>
515+
{_.includes(skill.sources, 'CHALLENGE') && <div styleName="verified-badge"><VerifiedBadgeIcon /></div> }
516+
</div>
517517
</div>
518518
</li>
519519
);

src/shared/components/Settings/Profile/Skills/styles.scss

Lines changed: 27 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,7 @@
228228
}
229229

230230
li {
231-
margin: 0 10px 55px;
231+
margin: 0 10px 10px;
232232
border-radius: 6px;
233233

234234
@include xs-to-lg {
@@ -261,14 +261,39 @@
261261
text-decoration: none;
262262
}
263263

264+
.name-wrapper {
265+
position: relative;
266+
display: flex;
267+
flex-direction: row;
268+
justify-content: center;
269+
align-items: center;
270+
width: 75px;
271+
padding: 5px 0px 10px;
272+
flex-shrink: 0;
273+
274+
.name {
275+
@include roboto-regular;
276+
277+
font-size: 12px;
278+
line-height: 15px;
279+
color: #262628;
280+
text-align: center;
281+
}
282+
283+
.verified-badge {
284+
padding-left: 5px;
285+
font-size: 0;
286+
}
287+
}
288+
264289
.skill-icon {
265290
position: relative;
266291
display: flex;
267292
flex-direction: column;
268293
justify-content: center;
269294
align-items: center;
270295
background-color: #fbfbfb;
271-
padding: 10px;
296+
padding: 0px 10px 0px;
272297
border: 1px solid $tc-gray-20;
273298
border-radius: 6px;
274299
height: 75px;
@@ -317,28 +342,6 @@
317342
}
318343
}
319344

320-
.name-wrapper {
321-
margin-top: 20px;
322-
display: flex;
323-
align-items: center;
324-
justify-content: center;
325-
326-
.name {
327-
@include roboto-regular;
328-
329-
font-size: 12px;
330-
line-height: 15px;
331-
color: #262628;
332-
text-align: center;
333-
width: 100%;
334-
}
335-
336-
.verified-badge {
337-
padding-left: 5px;
338-
font-size: 0;
339-
}
340-
}
341-
342345
a.skill-hidden {
343346
img {
344347
opacity: 0.3;

0 commit comments

Comments
 (0)