Skip to content

Commit 6f3c56e

Browse files
committed
Fix: Wrong links to MM details from challenge listing
Fixes #271, fixes #433
1 parent a4add07 commit 6f3c56e

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

src/shared/components/challenge-listing/ChallengeCard/NumRegistrants/index.jsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ const MM_BASE_URL
2323
= `${config.URL.COMMUNITY}/longcontest/?module=ViewRegistrants&rd=`;
2424

2525
export default function NumRegistrants({
26-
challenge: { id, numRegistrants, track },
26+
challenge: { id, numRegistrants, rounds, track },
2727
selectChallengeDetailsTab,
2828
}) {
2929
let tip;
@@ -34,7 +34,7 @@ export default function NumRegistrants({
3434
}
3535
const query = numRegistrants ? `?tab=${DETAIL_TABS.REGISTRANTS}` : '';
3636
const link = track === 'DATA_SCIENCE' && _.toString(id).length < ID_LENGTH
37-
? `${MM_BASE_URL}${id}` : `/challenges/${id}${query}`;
37+
? `${MM_BASE_URL}${rounds[0].id}` : `/challenges/${id}${query}`;
3838
return (
3939
<span styleName="container">
4040
<Tooltip
@@ -62,6 +62,7 @@ NumRegistrants.propTypes = {
6262
challenge: PT.shape({
6363
id: PT.oneOfType([PT.number, PT.string]).isRequired,
6464
numRegistrants: PT.number.isRequired,
65+
rounds: PT.arrayOf(PT.object).isRequired,
6566
track: PT.string.isRequired,
6667
}).isRequired,
6768
selectChallengeDetailsTab: PT.func.isRequired,

src/shared/components/challenge-listing/ChallengeCard/NumSubmissions/index.jsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ const MM_BASE_URL
2323
= `${config.URL.COMMUNITY}/longcontest/?module=ViewStandings&rd=`;
2424

2525
export default function NumSubmissions({
26-
challenge: { id, numSubmissions, track },
26+
challenge: { id, numSubmissions, rounds, track },
2727
selectChallengeDetailsTab,
2828
}) {
2929
let tip;
@@ -34,7 +34,7 @@ export default function NumSubmissions({
3434
}
3535
const query = numSubmissions ? `?tab=${DETAIL_TABS.SUBMISSIONS}` : '';
3636
const link = track === 'DATA_SCIENCE' && _.toString(id).length < ID_LENGTH
37-
? `${MM_BASE_URL}${id}` : `/challenges/${id}${query}`;
37+
? `${MM_BASE_URL}${rounds[0].id}` : `/challenges/${id}${query}`;
3838
return (
3939
<div styleName="container">
4040
<Tooltip
@@ -62,6 +62,7 @@ NumSubmissions.propTypes = {
6262
challenge: PT.shape({
6363
id: PT.oneOfType([PT.number, PT.string]).isRequired,
6464
numSubmissions: PT.number.isRequired,
65+
rounds: PT.arrayOf(PT.object).isRequired,
6566
track: PT.string.isRequired,
6667
}).isRequired,
6768
selectChallengeDetailsTab: PT.func.isRequired,

src/shared/components/challenge-listing/ChallengeCard/index.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ function ChallengeCard({
6868
/* TODO: Don't we have a better way, whether a challenge is MM or not? */
6969
const isMM = _.toString(challenge.id).length < ID_LENGTH;
7070
challengeDetailLink = isMM
71-
? `${mmDetailUrl}${challenge.id}`
71+
? `${mmDetailUrl}${challenge.rounds[0].id}`
7272
: `${challengeUrl}${challenge.id}/?type=develop`;
7373
} else {
7474
challengeDetailLink =

0 commit comments

Comments
 (0)