Skip to content

Commit 6860d3d

Browse files
committed
Fix issue #190
1 parent 9bae199 commit 6860d3d

File tree

1 file changed

+16
-0
lines changed
  • src/shared/containers/challenge-detail

1 file changed

+16
-0
lines changed

src/shared/containers/challenge-detail/index.jsx

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ import ChallengeCheckpoints from 'components/challenge-detail/Checkpoints';
2020
import React from 'react';
2121
import PT from 'prop-types';
2222
import { connect } from 'react-redux';
23+
import Error404 from 'components/Error404';
2324
import challengeActions from 'actions/challenge';
2425
import termsActions from 'actions/terms';
2526
import config from 'utils/config';
@@ -56,6 +57,10 @@ class ChallengeDetailPageContainer extends React.Component {
5657
const { challenge, loadChallengeDetails, loadTerms,
5758
openTermsModal, authTokens, challengeId } = this.props;
5859

60+
if (isNaN(challengeId)) {
61+
return;
62+
}
63+
5964
if (challenge.id !== challengeId) {
6065
loadChallengeDetails(authTokens, challengeId);
6166
}
@@ -68,6 +73,10 @@ class ChallengeDetailPageContainer extends React.Component {
6873
}
6974

7075
componentWillReceiveProps(nextProps) {
76+
if (isNaN(nextProps.challengeId)) {
77+
return;
78+
}
79+
7180
if (this.props.tokenV3 !== nextProps.tokenV3) {
7281
this.props.reloadChallengeDetails(nextProps.authTokens, this.props.challengeId);
7382
}
@@ -118,6 +127,10 @@ class ChallengeDetailPageContainer extends React.Component {
118127
}
119128

120129
render() {
130+
if (isNaN(this.props.challengeId)) {
131+
return <Error404 />;
132+
}
133+
121134
const isEmpty = _.isEmpty(this.props.challenge);
122135

123136
const hasRegistered = isRegistered(this.props.challenge.userDetails,
@@ -286,6 +299,9 @@ ChallengeDetailPageContainer.propTypes = {
286299

287300
function extractChallengeDetail(v3, v2, challengeId) {
288301
let challenge = {};
302+
if (isNaN(challengeId)) {
303+
return challenge;
304+
}
289305
if (!_.isEmpty(v3)) {
290306
challenge = _.clone(v3);
291307
if (!_.isEmpty(v2)) {

0 commit comments

Comments
 (0)