Skip to content

Commit 66f0603

Browse files
committed
Merge pull request #2962 from r0hit-gupta/msft37
MSFT-37
1 parent 9c237df commit 66f0603

File tree

2 files changed

+12
-3
lines changed

2 files changed

+12
-3
lines changed

__tests__/shared/components/challenge-listing/Filters/__snapshots__/ChallengeFilters.jsx.snap

+9
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,10 @@ exports[`Matches shallow shapshot shapshot 2`] = `
108108
/>
109109
<span>
110110
<span
111+
aria-checked={false}
112+
aria-label="Filter"
111113
className="src-shared-components-challenge-listing-Filters-___ChallengeFilters__filter-switch-with-label___21Ups"
114+
role="switch"
112115
>
113116
<ThemedSwitchWithLabel
114117
composeAdhocTheme="deeply"
@@ -122,7 +125,10 @@ exports[`Matches shallow shapshot shapshot 2`] = `
122125
/>
123126
</span>
124127
<span
128+
aria-checked={false}
129+
aria-label="Filter"
125130
className="src-shared-components-challenge-listing-Filters-___ChallengeFilters__filter-switch-with-label___21Ups"
131+
role="switch"
126132
>
127133
<ThemedSwitchWithLabel
128134
composeAdhocTheme="deeply"
@@ -136,7 +142,10 @@ exports[`Matches shallow shapshot shapshot 2`] = `
136142
/>
137143
</span>
138144
<span
145+
aria-checked={false}
146+
aria-label="Filter"
139147
className="src-shared-components-challenge-listing-Filters-___ChallengeFilters__filter-switch-with-label___21Ups"
148+
role="switch"
140149
>
141150
<ThemedSwitchWithLabel
142151
composeAdhocTheme="deeply"

src/shared/components/challenge-listing/Filters/ChallengeFilters.jsx

+3-3
Original file line numberDiff line numberDiff line change
@@ -76,21 +76,21 @@ export default function ChallengeFilters({
7676
isCardTypeSet === 'Challenges'
7777
? (
7878
<span>
79-
<span styleName="filter-switch-with-label">
79+
<span styleName="filter-switch-with-label" aria-label="Filter" role="switch" aria-checked={isTrackOn(TRACKS.DESIGN)}>
8080
<SwitchWithLabel
8181
enabled={isTrackOn(TRACKS.DESIGN)}
8282
labelBefore="Design"
8383
onSwitch={on => switchTrack(TRACKS.DESIGN, on)}
8484
/>
8585
</span>
86-
<span styleName="filter-switch-with-label">
86+
<span styleName="filter-switch-with-label" aria-label="Filter" role="switch" aria-checked={isTrackOn(TRACKS.DEVELOP)}>
8787
<SwitchWithLabel
8888
enabled={isTrackOn(TRACKS.DEVELOP)}
8989
labelBefore="Development"
9090
onSwitch={on => switchTrack(TRACKS.DEVELOP, on)}
9191
/>
9292
</span>
93-
<span styleName="filter-switch-with-label">
93+
<span styleName="filter-switch-with-label" aria-label="Filter" role="switch" aria-checked={isTrackOn(TRACKS.DATA_SCIENCE)}>
9494
<SwitchWithLabel
9595
enabled={isTrackOn(TRACKS.DATA_SCIENCE)}
9696
labelBefore="Data Science"

0 commit comments

Comments
 (0)