Skip to content

Commit 5ff3b23

Browse files
committed
Expand logic inside click handlers.
1 parent bd38288 commit 5ff3b23

File tree

3 files changed

+12
-8
lines changed

3 files changed

+12
-8
lines changed

src/shared/components/challenge-listing/Listing/Bucket/index.jsx

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,12 @@ export default function Bucket({
8888
{
8989
(expandable || loadMore) && !expanded ? (
9090
<button
91-
onClick={expand}
91+
onClick={() => {
92+
expand();
93+
/* eslint-env browser */
94+
document.body.scrollTop = 0;
95+
document.documentElement.scrollTop = 0;
96+
}}
9297
styleName="view-more"
9398
>View more challenges</button>
9499
) : null

src/shared/components/challenge-listing/Sidebar/BucketSelector/index.jsx

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,12 @@ export default function BucketSelector({
4343
bucket={buckets[bucket]}
4444
challenges={filteredChallenges}
4545
disabled={disabled}
46-
onClick={() => selectBucket(bucket)}
46+
onClick={() => {
47+
selectBucket(bucket);
48+
/* eslint-env browser */
49+
document.body.scrollTop = 0;
50+
document.documentElement.scrollTop = 0;
51+
}}
4752
/>
4853
);
4954

src/shared/components/challenge-listing/index.jsx

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -85,12 +85,6 @@ export default function ChallengeListing(props) {
8585
);
8686
}
8787

88-
/* eslint-env browser */
89-
if (document) {
90-
document.body.scrollTop = 0;
91-
document.documentElement.scrollTop = 0;
92-
}
93-
9488
return (
9589
<div styleName="ChallengeFiltersExample">
9690
<ChallengeFilters

0 commit comments

Comments
 (0)