Skip to content

Commit 5009021

Browse files
Fix issue: #4963
1 parent 46d11e6 commit 5009021

File tree

2 files changed

+21
-5
lines changed
  • src/shared

2 files changed

+21
-5
lines changed

src/shared/components/challenge-listing/Listing/index.jsx

+12-3
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,9 @@ import './style.scss';
2020
function Listing({
2121
activeBucket,
2222
auth,
23+
allActiveChallengesLoaded,
24+
allMyChallengesLoaded,
25+
allOpenForRegistrationChallengesLoaded,
2326
challenges,
2427
openForRegistrationChallenges,
2528
myChallenges,
@@ -86,17 +89,17 @@ function Listing({
8689
case BUCKETS.MY:
8790
bucketChallenges = [].concat(myChallenges);
8891
loading = loadingMyChallenges;
89-
loadMore = loadMoreMy;
92+
loadMore = allMyChallengesLoaded ? null : loadMoreMy;
9093
break;
9194
case BUCKETS.OPEN_FOR_REGISTRATION:
9295
bucketChallenges = [].concat(openForRegistrationChallenges);
9396
loading = loadingOpenForRegistrationChallenges;
94-
loadMore = loadMoreOpenForRegistration;
97+
loadMore = allOpenForRegistrationChallengesLoaded ? null : loadMoreOpenForRegistration;
9598
break;
9699
case BUCKETS.ONGOING:
97100
bucketChallenges = [].concat(challenges);
98101
loading = loadingOnGoingChallenges;
99-
loadMore = loadMoreOnGoing;
102+
loadMore = allActiveChallengesLoaded ? null : loadMoreOnGoing;
100103
break;
101104
default:
102105
break;
@@ -226,6 +229,9 @@ Listing.propTypes = {
226229
userId: PT.string,
227230
}),
228231
}).isRequired,
232+
allActiveChallengesLoaded: PT.bool.isRequired,
233+
allMyChallengesLoaded: PT.bool.isRequired,
234+
allOpenForRegistrationChallengesLoaded: PT.bool.isRequired,
229235
challenges: PT.arrayOf(PT.shape()),
230236
openForRegistrationChallenges: PT.arrayOf(PT.shape()),
231237
myChallenges: PT.arrayOf(PT.shape()),
@@ -268,6 +274,9 @@ const mapStateToProps = (state) => {
268274
const cl = state.challengeListing;
269275
return {
270276
// allActiveChallengesLoaded: cl.allActiveChallengesLoaded,
277+
allActiveChallengesLoaded: cl.allActiveChallengesLoaded,
278+
allMyChallengesLoaded: cl.allMyChallengesLoaded,
279+
allOpenForRegistrationChallengesLoaded: cl.allOpenForRegistrationChallengesLoaded,
271280
// pastSearchTimestamp: cl.pastSearchTimestamp,
272281
challengeTypes: cl.challengeTypes,
273282
};

src/shared/reducers/challenge-listing/index.js

+9-2
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,7 @@ function onGetActiveChallengesDone(state, { error, payload }) {
104104
challenges,
105105
// lastUpdateOfActiveChallenges: Date.now(),
106106
loadingActiveChallengesUUID: '',
107+
allActiveChallengesLoaded: challenges.length >= payload.meta.allChallengesCount,
107108
meta: {
108109
...state.meta,
109110
ongoingChallengesCount: payload.meta.allChallengesCount,
@@ -558,6 +559,7 @@ function onGetOpenForRegistrationChallengesDone(state, { error, payload }) {
558559
...state,
559560
openForRegistrationChallenges: challenges,
560561
loadingOpenForRegistrationChallengesUUID: '',
562+
allOpenForRegistrationChallengesLoaded: challenges.length >= payload.meta.allChallengesCount,
561563
meta: {
562564
...state.meta,
563565
openChallengesCount: payload.meta.allChallengesCount,
@@ -577,6 +579,7 @@ function onGetMyChallengesDone(state, { error, payload }) {
577579
...state,
578580
myChallenges: challenges,
579581
loadingMyChallengesUUID: '',
582+
allMyChallengesLoaded: challenges.length >= payload.meta.allChallengesCount,
580583
meta: {
581584
...state.meta,
582585
myChallengesCount: payload.meta.allChallengesCount,
@@ -619,7 +622,9 @@ function create(initialState) {
619622
return handleActions({
620623
[a.dropChallenges]: state => ({
621624
...state,
622-
// allActiveChallengesLoaded: false,
625+
allActiveChallengesLoaded: false,
626+
allMyChallengesLoaded: false,
627+
allOpenForRegistrationChallengesLoaded: false,
623628
// allPastChallengesLoaded: false,
624629
// allReviewOpportunitiesLoaded: false,
625630
challenges: [],
@@ -754,7 +759,9 @@ function create(initialState) {
754759
},
755760
}),
756761
}, _.defaults(_.clone(initialState) || {}, {
757-
// allActiveChallengesLoaded: false,
762+
allActiveChallengesLoaded: false,
763+
allMyChallengesLoaded: false,
764+
allOpenForRegistrationChallengesLoaded: false,
758765
// allPastChallengesLoaded: false,
759766
allReviewOpportunitiesLoaded: false,
760767

0 commit comments

Comments
 (0)