Skip to content

Commit 46c9b26

Browse files
authored
Merge pull request #16 from topcoder-platform/qa-accessibility
Qa accessibility
2 parents ad49caa + 36031e2 commit 46c9b26

File tree

32 files changed

+553
-1471
lines changed

32 files changed

+553
-1471
lines changed

__tests__/shared/components/ProfilePage/Skill/__snapshots__/index.jsx.snap

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ exports[`renders a skill correctly 1`] = `
55
className="src-shared-components-ProfilePage-Skill-___styles__container___bW089"
66
>
77
<div
8+
aria-label="Test Skill Icon"
89
className="src-shared-components-ProfilePage-Skill-___styles__skill-icon___1-d49"
910
>
1011
<FallbackIcon

__tests__/shared/components/TopcoderHeader/__snapshots__/Auth.jsx.snap

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,6 @@
33
exports[`Snapshot match 1`] = `
44
<div
55
className="src-shared-components-TopcoderHeader-Auth-___style__auth___3X0_r"
6-
onClick={[Function]}
7-
onKeyPress={null}
8-
role="button"
9-
tabIndex="0"
106
>
117
<a
128
className="tc-btn-sm tc-btn-primary"
@@ -27,10 +23,6 @@ exports[`Snapshot match 1`] = `
2723
exports[`Snapshot match 2`] = `
2824
<div
2925
className="column src-shared-components-TopcoderHeader-Auth-___style__auth___3X0_r"
30-
onClick={[Function]}
31-
onKeyPress={null}
32-
role="button"
33-
tabIndex="0"
3426
>
3527
<a
3628
className="tc-btn-sm tc-btn-primary"

__tests__/shared/components/TopcoderHeader/desktop/SubMenu/Item.jsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ test('Matches shallow shapshot', () => {
88
renderer.render((
99
<Item
1010
currentSubMenuTitle="title"
11-
icon="icon url"
11+
icon={<div />}
1212
title="title"
1313
link="menu url"
1414
/>
@@ -18,7 +18,7 @@ test('Matches shallow shapshot', () => {
1818
renderer.render((
1919
<Item
2020
currentSubMenuTitle="another title"
21-
icon="icon url"
21+
icon={<div />}
2222
title="title"
2323
link="menu url"
2424
/>

__tests__/shared/components/TopcoderHeader/desktop/SubMenu/__snapshots__/Item.jsx.snap

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,9 @@ exports[`Matches shallow shapshot 1`] = `
1111
openNewTab={false}
1212
to="menu url"
1313
>
14-
icon url
14+
<div
15+
aria-label="title"
16+
/>
1517
title
1618
</Link>
1719
</li>
@@ -28,7 +30,9 @@ exports[`Matches shallow shapshot 2`] = `
2830
openNewTab={false}
2931
to="menu url"
3032
>
31-
icon url
33+
<div
34+
aria-label="title"
35+
/>
3236
title
3337
</Link>
3438
</li>

__tests__/shared/components/__snapshots__/TopcoderFooter.jsx.snap

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ exports[`Matches shallow shapshot 1`] = `
55
className="src-shared-components-TopcoderFooter-___style__footer___28yQ6"
66
>
77
<nav>
8-
<ul>
8+
<ol>
99
<li
1010
className="src-shared-components-TopcoderFooter-___style__link___3-nzm"
1111
>
@@ -51,13 +51,14 @@ exports[`Matches shallow shapshot 1`] = `
5151
TERMS
5252
</a>
5353
</li>
54-
</ul>
54+
</ol>
5555
</nav>
5656
<div
5757
className="src-shared-components-TopcoderFooter-___style__social-links___2G4Ia"
5858
>
5959
<hr />
6060
<a
61+
aria-label="Facebook"
6162
href="https://www.facebook.com/topcoder"
6263
target="fbwindow"
6364
>
@@ -78,6 +79,7 @@ exports[`Matches shallow shapshot 1`] = `
7879
</svg>
7980
</a>
8081
<a
82+
aria-label="Twitter"
8183
href="http://www.twitter.com/topcoder"
8284
target="twwindow"
8385
>
@@ -98,6 +100,7 @@ exports[`Matches shallow shapshot 1`] = `
98100
</svg>
99101
</a>
100102
<a
103+
aria-label="Linkedin"
101104
href="https://www.linkedin.com/company/topcoder"
102105
target="liwindow"
103106
>
@@ -118,6 +121,7 @@ exports[`Matches shallow shapshot 1`] = `
118121
</svg>
119122
</a>
120123
<a
124+
aria-label="Instagram"
121125
href="https://www.instagram.com/topcoder"
122126
target="inwindow"
123127
>

__tests__/shared/components/challenge-listing/Filters/__snapshots__/ChallengeFilters.jsx.snap

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,10 @@ exports[`Matches shallow shapshot shapshot 2`] = `
108108
/>
109109
<span>
110110
<span
111+
aria-checked={false}
112+
aria-label="Filter"
111113
className="src-shared-components-challenge-listing-Filters-___ChallengeFilters__filter-switch-with-label___21Ups"
114+
role="switch"
112115
>
113116
<ThemedSwitchWithLabel
114117
composeAdhocTheme="deeply"
@@ -122,7 +125,10 @@ exports[`Matches shallow shapshot shapshot 2`] = `
122125
/>
123126
</span>
124127
<span
128+
aria-checked={false}
129+
aria-label="Filter"
125130
className="src-shared-components-challenge-listing-Filters-___ChallengeFilters__filter-switch-with-label___21Ups"
131+
role="switch"
126132
>
127133
<ThemedSwitchWithLabel
128134
composeAdhocTheme="deeply"
@@ -136,7 +142,10 @@ exports[`Matches shallow shapshot shapshot 2`] = `
136142
/>
137143
</span>
138144
<span
145+
aria-checked={false}
146+
aria-label="Filter"
139147
className="src-shared-components-challenge-listing-Filters-___ChallengeFilters__filter-switch-with-label___21Ups"
148+
role="switch"
140149
>
141150
<ThemedSwitchWithLabel
142151
composeAdhocTheme="deeply"

__tests__/shared/components/challenge-listing/Filters/__snapshots__/FiltersPanel.jsx.snap

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,9 +84,10 @@ exports[`Matches shallow shapshot 1`] = `
8484
options={
8585
Array [
8686
Object {
87-
"label": <div>
87+
"data": <div>
8888
Sample community
8989
</div>,
90+
"label": "Sample community",
9091
"name": "Sample community",
9192
"value": "123",
9293
},
@@ -299,9 +300,10 @@ exports[`Matches shallow shapshot 2`] = `
299300
options={
300301
Array [
301302
Object {
302-
"label": <div>
303+
"data": <div>
303304
Sample community
304305
</div>,
306+
"label": "Sample community",
305307
"name": "Sample community",
306308
"value": "123",
307309
},

0 commit comments

Comments
 (0)