Skip to content

Commit 3d9f5f0

Browse files
committed
Merge pull request #2976 from gets0ul/issue-2910
Fix for Issue #2910 - Don't read out title when menu open
1 parent 56c79db commit 3d9f5f0

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

src/shared/components/challenge-detail/Header/index.jsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ export default function ChallengeHeader(props) {
4747
selectedView,
4848
showDeadlineDetail,
4949
hasFirstPlacement,
50+
isMenuOpened,
5051
} = props;
5152

5253
const {
@@ -239,7 +240,7 @@ export default function ChallengeHeader(props) {
239240
return (
240241
<div styleName="challenge-outer-container">
241242
<div styleName="important-detail">
242-
<div styleName="title-wrapper">
243+
<div styleName="title-wrapper" aria-hidden={isMenuOpened}>
243244
<Link to={challengesUrl}>
244245
<LeftArrow styleName="left-arrow" />
245246
</Link>
@@ -421,6 +422,7 @@ Show Deadlines
421422

422423
ChallengeHeader.defaultProps = {
423424
checkpoints: {},
425+
isMenuOpened: false,
424426
};
425427

426428
ChallengeHeader.propTypes = {
@@ -462,4 +464,5 @@ ChallengeHeader.propTypes = {
462464
unregistering: PT.bool.isRequired,
463465
challengeSubtracksMap: PT.shape().isRequired,
464466
hasFirstPlacement: PT.bool.isRequired,
467+
isMenuOpened: PT.bool,
465468
};

src/shared/containers/challenge-detail/index.jsx

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -234,6 +234,7 @@ class ChallengeDetailPageContainer extends React.Component {
234234
unregisterFromChallenge,
235235
unregistering,
236236
updateChallenge,
237+
isMenuOpened,
237238
} = this.props;
238239

239240
const {
@@ -327,6 +328,7 @@ does not exist!
327328
hasRegistered={hasRegistered}
328329
hasFirstPlacement={hasFirstPlacement}
329330
challengeSubtracksMap={challengeSubtracksMap}
331+
isMenuOpened={isMenuOpened}
330332
/>
331333
)
332334
}
@@ -414,6 +416,7 @@ ChallengeDetailPageContainer.defaultProps = {
414416
// loadingCheckpointResults: false,
415417
results: null,
416418
terms: [],
419+
isMenuOpened: false,
417420
};
418421

419422
ChallengeDetailPageContainer.propTypes = {
@@ -456,6 +459,7 @@ ChallengeDetailPageContainer.propTypes = {
456459
unregisterFromChallenge: PT.func.isRequired,
457460
unregistering: PT.bool.isRequired,
458461
updateChallenge: PT.func.isRequired,
462+
isMenuOpened: PT.bool,
459463
};
460464

461465
function mapStateToProps(state, props) {
@@ -489,6 +493,7 @@ function mapStateToProps(state, props) {
489493
specsTabState: state.page.challengeDetails.specsTabState,
490494
terms: state.terms.terms,
491495
unregistering: state.challenge.unregistering,
496+
isMenuOpened: !!state.topcoderHeader.openedMenu,
492497
};
493498
}
494499

0 commit comments

Comments
 (0)