Skip to content

Commit 1f6997a

Browse files
Merge branch 'develop' into color-handles-leaderboards
2 parents 6be98f8 + fcf4c59 commit 1f6997a

File tree

8 files changed

+21
-23
lines changed

8 files changed

+21
-23
lines changed

.circleci/config.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -237,14 +237,14 @@ workflows:
237237
filters:
238238
branches:
239239
only:
240-
- color-handles-leaderboards
240+
- free
241241
# This is alternate dev env for parallel testing
242242
- "build-qa":
243243
context : org-global
244244
filters:
245245
branches:
246246
only:
247-
- free
247+
- seo-fix
248248
# This is beta env for production soft releases
249249
- "build-prod-beta":
250250
context : org-global
@@ -260,6 +260,7 @@ workflows:
260260
branches:
261261
only:
262262
- develop
263+
- listing-search
263264
# Production builds are exectuted
264265
# when PR is merged to the master
265266
# Don't change anything in this configuration
@@ -279,3 +280,4 @@ workflows:
279280
branches:
280281
ignore:
281282
- develop
283+

src/shared/components/GUIKit/DropdownTerms/index.jsx

Lines changed: 8 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -33,22 +33,12 @@ function DropdownTerms({
3333
let inputField;
3434
useEffect(() => {
3535
const selectInput = containerRef.current.getElementsByClassName('Select-input');
36-
const selectMenuOuter = containerRef.current.getElementsByClassName('Select-menu-outer');
3736
if (selectInput && selectInput.length) {
38-
const selectControl = containerRef.current.getElementsByClassName(
39-
'Select-control',
40-
);
41-
const height1 = selectMenuOuter && selectMenuOuter.length
42-
? selectMenuOuter[0].offsetHeight
43-
: 0;
44-
const height2 = selectControl && selectControl.length
45-
? selectControl[0].offsetHeight
46-
: 0;
47-
selectInput[0].style.top = focused ? `${height1 + height2 - 1}px` : '0';
4837
inputField = selectInput[0].getElementsByTagName('input');
4938
inputField[0].placeholder = focused ? addNewOptionPlaceholder : '';
5039
inputField[0].style.border = 'none';
5140
inputField[0].style.boxShadow = 'none';
41+
selectInput[0].style.borderTop = 'none';
5242
}
5343
}, [focused, selectedOption]);
5444

@@ -145,9 +135,13 @@ function DropdownTerms({
145135
backspaceRemoves={false}
146136
multi
147137
promptTextCreator={() => null}
148-
filterOptions={() => _.filter(
149-
internalTerms, t => !_.find(selectedOption, { label: t.label }),
150-
).map(o => ({ value: o.label, label: o.label }))}
138+
filterOptions={(option, inputValue) => _.filter(
139+
internalTerms,
140+
t => (inputValue && inputValue.length >= 2
141+
? t.label.toLowerCase().includes(inputValue.toLowerCase())
142+
&& !_.find(selectedOption, { label: t.label })
143+
: !_.find(selectedOption, { label: t.label })),
144+
)}
151145
/>
152146
<img width="15" height="9" styleName="iconDropdown" src={iconDown} alt="dropdown-arrow-icon" />
153147
</div>

src/shared/components/challenge-listing/Filters/ChallengeFilters.jsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ export default function ChallengeFilters({
6666

6767
const clearSearch = () => {
6868
// setFilterState(Filter.setText(filterState, ''));
69-
setFilterState({ ..._.clone(filterState), name: '' });
69+
setFilterState({ ..._.clone(filterState), search: '' });
7070
setSearchText('');
7171
};
7272

@@ -77,7 +77,7 @@ export default function ChallengeFilters({
7777
onSearch={(text) => {
7878
// console.log('search text');
7979
// console.log(text);
80-
setFilterState({ ..._.clone(filterState), name: text });
80+
setFilterState({ ..._.clone(filterState), search: text });
8181
}}
8282
// onSearch={text => setFilterState(Filter.setText(filterState, text))}
8383
onClearSearch={() => clearSearch()}

src/shared/components/challenge-listing/Filters/FiltersPanel/index.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -425,7 +425,7 @@ export default function FiltersPanel({
425425
DS: true,
426426
QA: true,
427427
},
428-
name: '',
428+
search: '',
429429
tags: [],
430430
types: [],
431431
groups: [],

src/shared/containers/Gigs/RecruitCRMJobApply.jsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,9 @@ class RecruitCRMJobApplyContainer extends React.Component {
125125
}
126126
// require atleast 1 skill
127127
if (!prop || prop === 'skills') {
128-
if (!_.find(formData.skills, { selected: true })) formErrors.skills = 'Please, add technical skills';
128+
const skills = _.filter(formData.skills, ['selected', true]);
129+
if (!skills.length) formErrors.skills = 'Please, add technical skills';
130+
else if (skills.map(skill => skill.label).join(',').length >= 100) formErrors.skills = 'Sum of all skill characters may not be greater than 100';
129131
else delete formErrors.skills;
130132
}
131133
// have accepted terms

src/shared/containers/challenge-detail/index.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -429,7 +429,7 @@ class ChallengeDetailPageContainer extends React.Component {
429429
image={getOgImage(challenge)}
430430
siteName="Topcoder"
431431
socialDescription={description}
432-
socialTitle={`${prizesStr}${title}`}
432+
socialTitle={`${prizesStr}${challenge.name}`}
433433
title={title}
434434
/>
435435
)

src/shared/containers/challenge-listing/Listing/index.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -568,7 +568,7 @@ export class ListingContainer extends React.Component {
568568
reviewOpportunities={reviewOpportunities}
569569
setFilterState={(state) => {
570570
setFilter(state);
571-
setSearchText(state.name || '');
571+
setSearchText(state.search || '');
572572
// if (activeBucket === BUCKETS.SAVED_FILTER) {
573573
// selectBucket(BUCKETS.OPEN_FOR_REGISTRATION);
574574
// } else if (activeBucket === BUCKETS.SAVED_REVIEW_OPPORTUNITIES_FILTER) {

src/shared/utils/challenge-listing/buckets.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ export function filterChanged(filter, prevFilter) {
171171
return true;
172172
}
173173
return (!_.isEqual(filter.tracks, prevFilter.tracks))
174-
|| (filter.name !== prevFilter.name)
174+
|| (filter.search !== prevFilter.search)
175175
|| (filter.status !== prevFilter.status)
176176
|| (filter.startDateEnd !== prevFilter.startDateEnd)
177177
|| (filter.endDateStart !== prevFilter.endDateStart)

0 commit comments

Comments
 (0)