Skip to content

Commit 1d4bdc8

Browse files
authored
Merge pull request #5255 from topcoder-platform/develop
Release 2020/12/11 (v1.6.4)
2 parents c8476a3 + 8edd563 commit 1d4bdc8

File tree

18 files changed

+91
-39
lines changed

18 files changed

+91
-39
lines changed

.circleci/config.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,7 @@ workflows:
237237
filters:
238238
branches:
239239
only:
240-
- gig-apply-fixes
240+
- hall-of-fame-fixes
241241
# This is alternate dev env for parallel testing
242242
- "build-qa":
243243
context : org-global

__tests__/shared/components/Leaderboard/__snapshots__/LeaderboardTable.jsx.snap

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,11 @@ exports[`Matches shallow shapshot 1`] = `
5656
>
5757
<a
5858
href="undefined/members/undefined/"
59+
style={
60+
Object {
61+
"color": null,
62+
}
63+
}
5964
target="_blank"
6065
/>
6166
<div
@@ -103,6 +108,11 @@ exports[`Matches shallow shapshot 1`] = `
103108
>
104109
<a
105110
href="undefined/members/undefined/"
111+
style={
112+
Object {
113+
"color": null,
114+
}
115+
}
106116
target="_blank"
107117
/>
108118
<div
@@ -150,6 +160,11 @@ exports[`Matches shallow shapshot 1`] = `
150160
>
151161
<a
152162
href="undefined/members/undefined/"
163+
style={
164+
Object {
165+
"color": null,
166+
}
167+
}
153168
target="_blank"
154169
/>
155170
<div
@@ -197,6 +212,11 @@ exports[`Matches shallow shapshot 1`] = `
197212
>
198213
<a
199214
href="undefined/members/undefined/"
215+
style={
216+
Object {
217+
"color": null,
218+
}
219+
}
200220
target="_blank"
201221
/>
202222
<div
Lines changed: 1 addition & 1 deletion
Loading

src/shared/components/GUIKit/JobListCard/index.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ export default function JobListCard({
3636
<IconBlackLocation /> {job.country}
3737
</div>
3838
<div styleName="icon-val">
39-
<IconBlackPayment /> ${job.min_annual_salary} - ${job.max_annual_salary} / {getSalaryType(job.salary_type)}
39+
<IconBlackPayment /> ${job.min_annual_salary} - {job.max_annual_salary} (USD) / {getSalaryType(job.salary_type)}
4040
</div>
4141
<div styleName="icon-val">
4242
<IconBlackDuration /> {getCustomField(job.custom_fields, 'Duration')}

src/shared/components/Gigs/GigDetails/index.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ export default function GigDetails(props) {
4444
let skills = getCustomField(job.custom_fields, 'Technologies Required');
4545
if (skills !== 'n/a') skills = skills.split(',').join(', ');
4646
const hPerW = getCustomField(job.custom_fields, 'Hours per week');
47-
const compens = job.min_annual_salary === job.max_annual_salary ? job.max_annual_salary : `${job.min_annual_salary} - ${job.max_annual_salary}`;
47+
const compens = job.min_annual_salary === job.max_annual_salary ? job.max_annual_salary : `${job.min_annual_salary} - ${job.max_annual_salary} (USD)`;
4848

4949
return (
5050
<div styleName="container">

src/shared/components/HallOfFamePage/Finalists/index.jsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ function findTheme(track) {
3434
case 'DEVELOPMENT':
3535
case 'FIRST2FINISH':
3636
case 'MOD DASH':
37+
case 'QA':
3738
return developmentAndFirst2finishTheme;
3839
case 'STUDIO':
3940
case 'UI DESIGN':

src/shared/components/HallOfFamePage/FunFacts/styles.scss

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
@import "~styles/mixins";
22

33
.container {
4-
align-items: center;
4+
align-items: stretch;
55
display: flex;
66
justify-content: space-between;
77

@@ -15,7 +15,6 @@
1515
.fact {
1616
background-color: #fff;
1717
border-radius: 4px;
18-
height: 330px;
1918
width: 360px;
2019

2120
@include xs-to-lg {
@@ -48,10 +47,10 @@
4847
border-top: solid 4px #5cc900;
4948
color: #000;
5049
font-size: 15px;
51-
height: 150px;
5250
line-height: 25px;
5351
padding: 15px;
5452
text-align: left;
53+
margin-top: -3px;
5554

5655
a,
5756
a:visited {

src/shared/components/HallOfFamePage/HoF.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -243,7 +243,7 @@ const HallOfFamePage = ({ eventId, hallOfFame }) => {
243243
{
244244
data.fields.spiritAwardWinners && (
245245
<div styleName="spirit-awards">
246-
<h3>Spirit Award</h3>
246+
<h3>SPIRIT AWARD WINNER</h3>
247247
<div styleName="spirit-awards-wrap">
248248
{
249249
_.map(

src/shared/components/HallOfFamePage/styles.scss

Lines changed: 19 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -179,6 +179,7 @@
179179

180180
img {
181181
min-height: 375px;
182+
max-height: 100%;
182183
width: 100%;
183184
}
184185

@@ -253,6 +254,7 @@
253254
margin: 0;
254255
padding: 0;
255256
width: 127px;
257+
white-space: nowrap;
256258
}
257259

258260
margin: 7px;
@@ -374,13 +376,23 @@
374376
}
375377

376378
.spirit-awards {
377-
margin-top: 50px;
379+
margin: 40px auto 60px auto;
378380
display: flex;
379381
flex-direction: column;
380-
align-items: center;
382+
border: 1px solid #e2c6f3;
383+
border-radius: 4px;
384+
width: 173px;
381385

382386
h3 {
383-
margin-bottom: 20px;
387+
margin: 0;
388+
background-color: #914da5;
389+
border-radius: 4px 4px 0 0;
390+
color: #fff;
391+
font-family: Roboto, sans-serif;
392+
font-size: 13px;
393+
line-height: 30px;
394+
text-align: center;
395+
font-weight: bold;
384396
}
385397

386398
.spirit-awards-wrap {
@@ -390,5 +402,9 @@
390402
a {
391403
font-size: 16px;
392404
}
405+
406+
p {
407+
margin: 0;
408+
}
393409
}
394410
}

src/shared/components/Leaderboard/ChallengeHistoryModal/styles.scss

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,6 @@ $light-gray: #d4d4d4;
6363
img,
6464
svg {
6565
border-radius: 50%;
66-
border-style: solid;
67-
border-width: 3px;
6866
height: 100%;
6967
width: 100%;
7068
}

src/shared/components/Leaderboard/LeaderboardTable/index.jsx

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ import { Avatar } from 'topcoder-react-ui-kit';
2929
import { config } from 'topcoder-react-utils';
3030
import _ from 'lodash';
3131
import DefaultAvatar from 'assets/images/default-avatar-photo.svg';
32+
import { getRatingColor } from 'utils/tc';
3233

3334

3435
import avatarStyles from '../avatarStyles.scss';
@@ -68,6 +69,7 @@ export default function LeaderboardTable(props) {
6869
const fulfillment = competitor['tco_leaderboard.fulfillment']
6970
? (parseFloat(competitor['tco_leaderboard.fulfillment']) * 100).toFixed(2).replace(/[.,]00$/, '')
7071
: competitor.fulfillment;
72+
const rating = competitor['member_profile_basic.max_rating'];
7173
return (
7274
<tr key={competitor.rank}>
7375
<td styleName={`${stylesName}.col-rank`}>{competitor.rank}</td>
@@ -91,11 +93,16 @@ export default function LeaderboardTable(props) {
9193
<div
9294
styleName={`${stylesName}.handle-link`}
9395
onClick={() => onUsernameClick(competitor)}
96+
style={{ color: rating ? getRatingColor(rating) : null }}
9497
>
9598
{competitor['member_profile_basic.handle'] || competitor.handle}
9699
</div>
97100
) : (
98-
<a href={`${window.origin}/members/${competitor['member_profile_basic.handle'] || competitor.handle}/`} target={`${_.includes(window.origin, 'www') ? '_self' : '_blank'}`}>
101+
<a
102+
href={`${window.origin}/members/${competitor['member_profile_basic.handle'] || competitor.handle}/`}
103+
target={`${_.includes(window.origin, 'www') ? '_self' : '_blank'}`}
104+
style={{ color: rating ? getRatingColor(rating) : null }}
105+
>
99106
{competitor['member_profile_basic.handle'] || competitor.handle}
100107
</a>
101108
)

src/shared/components/Leaderboard/LeaderboardTable/themes/tco20.scss

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
@import '~styles/mixins';
2-
$table-cell-padding: 8px;
2+
$table-cell-padding: 2px;
33
$table-border-color: #d4d4d4;
44
$table-bg-hover: #f5f5f5;
55

@@ -115,13 +115,13 @@ $table-bg-hover: #f5f5f5;
115115

116116
.col-avatar .leaderboard-avatar {
117117
display: inline-block;
118-
height: 40px;
119-
width: 40px;
118+
height: 34px;
119+
width: 34px;
120120
overflow: hidden;
121121

122122
svg {
123-
border: 3px solid rgba(0, 0, 0, 0.05);
124123
border-radius: 50%;
124+
max-width: 100%;
125125
}
126126
}
127127

src/shared/components/Leaderboard/Podium/styles.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
@include roboto-regular;
55

66
line-height: 1.42;
7-
margin: 0 auto 40px auto;
7+
margin: 0 auto 10px auto;
88
text-align: center;
99

1010
&::before,

src/shared/components/Leaderboard/PodiumSpot/index.jsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ import { Avatar } from 'topcoder-react-ui-kit';
3030
import { config } from 'topcoder-react-utils';
3131
import _ from 'lodash';
3232
import DefaultAvatar from 'assets/images/default-avatar-photo.svg';
33+
import { getRatingColor } from 'utils/tc';
3334

3435
import avatarStyles from '../avatarStyles.scss';
3536
import defaultStyles from './themes/styles.scss'; // eslint-disable-line
@@ -110,7 +111,7 @@ export default function PodiumSpot(props) {
110111
const fulfillment = competitor['tco_leaderboard.fulfillment']
111112
? (parseFloat(competitor['tco_leaderboard.fulfillment']) * 100).toFixed(2).replace(/[.,]00$/, '')
112113
: competitor.fulfillment;
113-
114+
const rating = competitor['member_profile_basic.max_rating'];
114115
return (
115116
<div styleName={rootStyle}>
116117
<span styleName={`${stylesName}.leaderboard-avatar`}>
@@ -159,6 +160,7 @@ export default function PodiumSpot(props) {
159160
<div
160161
styleName={`${stylesName}.handle-link`}
161162
onClick={() => onUsernameClick(competitor)}
163+
style={{ color: rating ? getRatingColor(rating) : null }}
162164
>
163165
{competitor['member_profile_basic.handle'] || competitor.handle}
164166
</div>
@@ -167,6 +169,7 @@ export default function PodiumSpot(props) {
167169
styleName={`${stylesName}.profile-link`}
168170
href={`${window.origin}/members/${competitor['member_profile_basic.handle'] || competitor.handle}/`}
169171
target={`${_.includes(window.origin, 'www') ? '_self' : '_blank'}`}
172+
style={{ color: rating ? getRatingColor(rating) : null }}
170173
>
171174
{competitor['member_profile_basic.handle'] || competitor.handle}
172175
</a>

src/shared/components/Leaderboard/PodiumSpot/themes/tco20.scss

Lines changed: 18 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -11,20 +11,24 @@ $podium-border-color: #ededf2;
1111
display: inline-block;
1212
position: relative;
1313
margin-bottom: 12px;
14-
margin-right: 20px;
14+
margin-right: 11px;
1515
overflow: visible;
1616
}
1717

1818
.ranking {
1919
@include roboto-black;
2020

2121
border-radius: 20px;
22-
padding: 3px 9px;
23-
display: inline-block;
22+
display: flex;
23+
padding: 0;
24+
align-items: center;
25+
justify-content: center;
2426
position: absolute;
2527
right: 0;
2628
bottom: -10px;
2729
font-size: 15px;
30+
width: 28px;
31+
height: 28px;
2832
}
2933

3034
.winnings-info span {
@@ -91,12 +95,13 @@ $podium-border-color: #ededf2;
9195
.handle-link,
9296
a.profile-link {
9397
color: #0d61bf;
94-
font-family: Barlow, sans-serif;
98+
font-family: Roboto, sans-serif;
9599
font-size: 16px;
96100
font-weight: 600;
97-
line-height: 19px;
101+
line-height: 24px;
98102
text-align: left;
99103
text-decoration: underline;
104+
margin-top: 11px;
100105
margin-bottom: 13px;
101106

102107
&:hover {
@@ -110,37 +115,37 @@ $podium-border-color: #ededf2;
110115
}
111116

112117
.PodiumSpot--first {
113-
background-color: #ffd84d;
118+
background-color: #f4f4f4;
114119

115120
.ranking {
116-
background-color: #2a2a2a;
121+
background-color: #ffd84d;
117122
color: #fff;
118123
}
119124
}
120125

121126
.PodiumSpot--second {
122-
background-color: #d4d4d4;
127+
background-color: #f4f4f4;
123128

124129
.ranking {
125-
background-color: #2a2a2a;
130+
background-color: #746b65;
126131
color: #fff;
127132
}
128133
}
129134

130135
.PodiumSpot--third {
131-
background-color: #f1a87d;
136+
background-color: #f4f4f4;
132137

133138
.ranking {
134-
background-color: #2a2a2a;
139+
background-color: #854e29;
135140
color: #fff;
136141
}
137142
}
138143

139144
.PodiumSpot--fourth {
140-
background-color: #8dccd4;
145+
background-color: #f4f4f4;
141146

142147
.ranking {
143-
background-color: #2a2a2a;
148+
background-color: #1e94a3;
144149
color: #fff;
145150
}
146151
}

0 commit comments

Comments
 (0)