Skip to content

Commit 1752611

Browse files
authored
Merge pull request #10 from topcoder-platform/qa-accessibility
Qa accessibility
2 parents f78e824 + 4f402f6 commit 1752611

File tree

10 files changed

+33
-32
lines changed

10 files changed

+33
-32
lines changed

src/assets/images/ico-arrow-big-left.svg

Lines changed: 0 additions & 1 deletion
Loading

src/shared/components/SubmissionPage/Submit/index.jsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -190,9 +190,9 @@ class Submit extends React.Component {
190190
>
191191
<div styleName="row">
192192
<div styleName="left">
193-
<h4>
193+
<h2>
194194
{ isChallengeBelongToTopgearGroup ? 'URL' : 'FILES'}
195-
</h4>
195+
</h2>
196196
<p>
197197
Please follow the instructions on the Challenge Details page regarding
198198
what your submission should contain and how it should be organized.

src/shared/components/SubmissionPage/Submit/styles.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@
9393
}
9494
}
9595

96-
h4 {
96+
h2 {
9797
font-size: 15px;
9898
line-height: 25px;
9999
margin-bottom: 4px;

src/shared/components/challenge-detail/Header/DeadlinesPanel/Card/style.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424

2525
.title {
2626
font-size: 13px;
27-
color: $tc-gray-40;
27+
color: $tc-gray-10;
2828
letter-spacing: 0;
2929
line-height: 15px;
3030
margin-bottom: 5px;

src/shared/components/challenge-detail/Header/DeadlinesPanel/style.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
.timezone {
1212
@include tc-label-sm;
1313

14-
color: $tc-gray-40;
14+
color: $tc-gray-10;
1515
position: absolute;
1616
right: 12px;
1717
bottom: 6px;

src/shared/components/challenge-detail/Header/TabSelector/style.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@
2323

2424
.challenge-selected-view {
2525
font-weight: 700;
26-
color: $tc-dark-blue;
27-
border-bottom: 3px solid $tc-dark-blue;
26+
color: $tc-dark-blue-110;
27+
border-bottom: 3px solid $tc-dark-blue-110;
2828
}
2929

3030
.challenge-unselected-view {

src/shared/components/challenge-detail/Header/index.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,7 @@ export default function ChallengeHeader(props) {
241241
<div styleName="challenge-outer-container">
242242
<div styleName="important-detail">
243243
<div styleName="title-wrapper" aria-hidden={isMenuOpened}>
244-
<Link to={challengesUrl}>
244+
<Link to={challengesUrl} aria-label="Back to challenge list">
245245
<LeftArrow styleName="left-arrow" />
246246
</Link>
247247
<div>

src/shared/components/challenge-detail/Header/style.scss

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@
164164

165165
margin-top: 20px;
166166
font-size: 10px;
167-
color: $tc-gray-50;
167+
color: $tc-gray-60;
168168
line-height: 10px;
169169
letter-spacing: 1.33px;
170170
}
@@ -188,13 +188,13 @@
188188
@include roboto-regular;
189189

190190
font-size: 13px;
191-
color: $tc-gray-50;
191+
color: $tc-gray-60;
192192
letter-spacing: 0;
193193
line-height: 15px;
194194
margin-bottom: 5px;
195195

196196
.rank-ordinal {
197-
color: $tc-gray-50;
197+
color: $tc-gray-60;
198198
}
199199
}
200200

@@ -265,7 +265,7 @@
265265

266266
display: flex;
267267
justify-content: flex-start;
268-
color: $tc-gray-30;
268+
color: $tc-gray-10;
269269
line-height: 20px;
270270
padding: 15px 20px;
271271
font-size: 15px;
@@ -296,7 +296,7 @@
296296
@include roboto-medium;
297297

298298
font-size: 13px;
299-
color: $tc-gray-20;
299+
color: $tc-gray-10;
300300
letter-spacing: 0;
301301
line-height: 20px;
302302
padding: 15px 20px;

src/shared/components/challenge-detail/Registrants/index.jsx

Lines changed: 17 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -59,24 +59,24 @@ export default function Registrants({ challenge, checkpointResults, results }) {
5959
- new Date(b.registrationDate).getTime());
6060

6161
return (
62-
<div styleName={`container ${twoRounds ? 'design' : ''}`}>
63-
<div styleName="head">
62+
<div styleName={`container ${twoRounds ? 'design' : ''}`} role="table" aria-label="Registrants">
63+
<div styleName="head" role="row">
6464
<div styleName="col-1">
65-
Username
65+
<span role="columnheader">Username</span>
6666
</div>
6767
<div styleName="col-2">
68-
Registration Date
68+
<span role="columnheader">Registration Date</span>
6969
</div>
7070
{twoRounds && (
7171
<div styleName="col-3">
72-
Round 1 Submitted Date
72+
<span role="columnheader">Round 1 Submitted Date</span>
7373
</div>
7474
)}
7575
<div styleName="col-4">
76-
{twoRounds ? 'Round 2 Submitted Date' : 'Submitted Date'}
76+
<span role="columnheader">{twoRounds ? 'Round 2 Submitted Date' : 'Submitted Date'}</span>
7777
</div>
7878
</div>
79-
<div styleName="body">
79+
<div styleName="body" role="rowgroup">
8080
{
8181
registrants.map((r) => {
8282
const placement = getPlace(results, r.handle, places);
@@ -98,17 +98,19 @@ Round 1 Submitted Date
9898
}
9999

100100
return (
101-
<div styleName="row" key={r.handle}>
101+
<div styleName="row" key={r.handle} role="row">
102102
<div styleName="col-1">
103-
<a href={`${config.URL.BASE}/members/${r.handle}`} style={colorStyle}>
104-
{r.handle}
105-
</a>
103+
<span role="cell">
104+
<a href={`${config.URL.BASE}/members/${r.handle}`} style={colorStyle}>
105+
{r.handle}
106+
</a>
107+
</span>
106108
</div>
107109
<div styleName="col-2">
108110
<div styleName="sm-only title">
109111
Registration Date
110112
</div>
111-
{formatDate(r.registrationDate)}
113+
<span role="cell">{formatDate(r.registrationDate)}</span>
112114
</div>
113115
{
114116
twoRounds
@@ -118,7 +120,7 @@ Registration Date
118120
Round 1 Submitted Date
119121
</div>
120122
<div>
121-
<span>
123+
<span role="cell">
122124
{checkpoint}
123125
</span>
124126
{
@@ -135,11 +137,11 @@ Round 1 Submitted Date
135137
Submitted Date
136138
</div>
137139
<div>
138-
<span>
140+
<span role="cell">
139141
{final}
140142
</span>
141143
{placement > 0 && (
142-
<span styleName={`placement ${placement < 4 ? `placement-${placement}` : ''}`}>
144+
<span role="cell" styleName={`placement ${placement < 4 ? `placement-${placement}` : ''}`}>
143145
{placement}
144146
</span>
145147
)}

src/shared/components/challenge-listing/ChallengeCard/Prize/index.jsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,14 +20,14 @@ export default function Prize({
2020
}) {
2121
const component = (
2222
// eslint-disable-next-line jsx-a11y/no-noninteractive-tabindex
23-
<div tabIndex={0} role="figure" aria-label={`${label} ${prizeUnitSymbol} ${totalPrize.toLocaleString()}`}>
24-
<div styleName="prize">
23+
<div tabIndex={0} aria-label={`${label} ${prizeUnitSymbol} ${totalPrize.toLocaleString()}`}>
24+
<div styleName="prize" aria-hidden="true">
2525
<span styleName="symbol">
2626
{prizeUnitSymbol}
2727
</span>
2828
{totalPrize.toLocaleString()}
2929
</div>
30-
<div styleName="label">
30+
<div styleName="label" aria-hidden="true">
3131
{label}
3232
</div>
3333
</div>

0 commit comments

Comments
 (0)