Merge pull request #9 from topcoder-platform/qa-accessibility

Qa accessibility

Author: PrakashDurlabhji

.circleci/config.yml

@@ -184,6 +184,7 @@ workflows:
                 only:
                   - legacy-tco
                   - hot-fixes-3
+                  - qa-accessibility
       # This is beta env for production soft releases
       - "build-prod-beta":
           context : org-global

.eslintrc

@@ -2,7 +2,8 @@
   "extends": "./node_modules/topcoder-react-utils/config/eslint/default.json",
   "rules": {
     "jsx-a11y/anchor-is-valid": false,
-    "import/no-cycle": [2, { "maxDepth": 1 }]
+    "import/no-cycle": [2, { "maxDepth": 1 }],
+    "react/prop-types": ["error", { "ignore": ["challenge","eventDetails","winner","bucket","theme","submissionObject","profile","communitiesList","meta","scoreboard","item","activeTrigger","menuItems","scoreboard"] }]
   },
   "env": {
     "browser": true

__tests__/shared/__snapshots__/index.jsx.snap

@@ -5,6 +5,11 @@ exports[`Snapshot match 1`] = `
   <HelmetWrapper
     defer={true}
     encodeSpecialCharacters={true}
+    htmlAttributes={
+      Object {
+        "lang": "en",
+      }
+    }
   >
     <meta
       content="#FFFFFF"
@@ -34,6 +39,11 @@ exports[`Snapshot match 2`] = `
   <HelmetWrapper
     defer={true}
     encodeSpecialCharacters={true}
+    htmlAttributes={
+      Object {
+        "lang": "en",
+      }
+    }
   >
     <meta
       content="#FFFFFF"

__tests__/shared/components/ProfilePage/Header/__snapshots__/index.jsx.snap

@@ -21,7 +21,7 @@ exports[`renders profile about header correctly 1`] = `
       className="src-shared-components-ProfilePage-Header-___styles__handle___-v11j"
       style={
         Object {
-          "color": "#9D9FA0",
+          "color": "#555555",
         }
       }
     >

__tests__/shared/components/TopcoderHeader/__snapshots__/index.jsx.snap

@@ -9,6 +9,7 @@ exports[`Default render 1`] = `
     className="src-shared-components-TopcoderHeader-___style__main-desktop-header___oqm_l"
   >
     <a
+      aria-label="Topcoder Homepage"
       className="src-shared-components-TopcoderHeader-___style__logo___2WLJ0"
       href="https://www.topcoder-dev.com"
     >
@@ -29,7 +30,12 @@ exports[`Default render 1`] = `
         onMouseLeave={[Function]}
         onTouchStart={[Function]}
       >
-        Compete
+        <span
+          role="link"
+          tabIndex={0}
+        >
+          Compete
+        </span>
       </li>
       <li
         className="src-shared-components-TopcoderHeader-___style__main-menu-item___2KIu6"
@@ -51,7 +57,12 @@ exports[`Default render 1`] = `
         onMouseLeave={[Function]}
         onTouchStart={[Function]}
       >
-        Community
+        <span
+          role="link"
+          tabIndex={0}
+        >
+          Community
+        </span>
       </li>
     </ul>
     <div
@@ -274,6 +285,7 @@ exports[`Render with open menu 1`] = `
     className="src-shared-components-TopcoderHeader-___style__main-desktop-header___oqm_l"
   >
     <a
+      aria-label="Topcoder Homepage"
       className="src-shared-components-TopcoderHeader-___style__logo___2WLJ0"
       href="https://www.topcoder-dev.com"
     >
@@ -294,7 +306,12 @@ exports[`Render with open menu 1`] = `
         onMouseLeave={[Function]}
         onTouchStart={[Function]}
       >
-        Compete
+        <span
+          role="link"
+          tabIndex={0}
+        >
+          Compete
+        </span>
       </li>
       <li
         className="src-shared-components-TopcoderHeader-___style__main-menu-item___2KIu6"
@@ -316,7 +333,12 @@ exports[`Render with open menu 1`] = `
         onMouseLeave={[Function]}
         onTouchStart={[Function]}
       >
-        Community
+        <span
+          role="link"
+          tabIndex={0}
+        >
+          Community
+        </span>
       </li>
     </ul>
     <div
@@ -550,6 +572,7 @@ exports[`Render with specified profile 1`] = `
     className="src-shared-components-TopcoderHeader-___style__main-desktop-header___oqm_l"
   >
     <a
+      aria-label="Topcoder Homepage"
       className="src-shared-components-TopcoderHeader-___style__logo___2WLJ0"
       href="https://www.topcoder-dev.com"
     >
@@ -570,7 +593,12 @@ exports[`Render with specified profile 1`] = `
         onMouseLeave={[Function]}
         onTouchStart={[Function]}
       >
-        Compete
+        <span
+          role="link"
+          tabIndex={0}
+        >
+          Compete
+        </span>
       </li>
       <li
         className="src-shared-components-TopcoderHeader-___style__main-menu-item___2KIu6"
@@ -592,7 +620,12 @@ exports[`Render with specified profile 1`] = `
         onMouseLeave={[Function]}
         onTouchStart={[Function]}
       >
-        Community
+        <span
+          role="link"
+          tabIndex={0}
+        >
+          Community
+        </span>
       </li>
     </ul>
     <div
@@ -609,7 +642,7 @@ exports[`Render with specified profile 1`] = `
           className="src-shared-components-TopcoderHeader-___style__user-menu-handle___r6kbg"
           style={
             Object {
-              "color": "#9D9FA0",
+              "color": "#555555",
             }
           }
         />

__tests__/shared/components/TopcoderHeader/mobile/__snapshots__/UserMenu.jsx.snap

@@ -18,7 +18,7 @@ exports[`Snapshot match 1`] = `
         className="src-shared-components-TopcoderHeader-mobile-UserMenu-___style__handle___CL0Tq"
         style={
           Object {
-            "color": "#9D9FA0",
+            "color": "#555555",
           }
         }
       >

__tests__/shared/components/__snapshots__/Handle.jsx.snap

@@ -6,7 +6,7 @@ exports[`Matches shallow shapshot 1`] = `
   href=""
   style={
     Object {
-      "color": "#9D9FA0",
+      "color": "#555555",
       "fontSize": "24px",
     }
   }

__tests__/shared/components/challenge-listing/Filters/__snapshots__/FiltersSwitch.jsx.snap

@@ -5,6 +5,8 @@ exports[`Matches shallow shapshot 1`] = `
   className="tc-outline-btn name src-shared-components-challenge-listing-Filters-FiltersSwitch-___style__FiltersSwitch___2ixiH"
   onClick={[Function]}
   onKeyPress={[Function]}
+  role="button"
+  tabIndex={0}
 >
   <FiltersIcon
     className="src-shared-components-challenge-listing-Filters-FiltersSwitch-___style__FiltersIcon___OqBJh"
@@ -22,6 +24,8 @@ exports[`Matches shallow shapshot 2`] = `
   className="tc-outline-btn name src-shared-components-challenge-listing-Filters-FiltersSwitch-___style__FiltersSwitch___2ixiH src-shared-components-challenge-listing-Filters-FiltersSwitch-___style__active___2wLTl"
   onClick={[Function]}
   onKeyPress={[Function]}
+  role="button"
+  tabIndex={0}
 >
   <FiltersIcon
     className="src-shared-components-challenge-listing-Filters-FiltersSwitch-___style__FiltersIcon___OqBJh"