Skip to content

[$60] Fix up the Gantt charts #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jmgasper opened this issue Apr 27, 2020 · 11 comments
Closed

[$60] Fix up the Gantt charts #175

jmgasper opened this issue Apr 27, 2020 · 11 comments

Comments

@jmgasper
Copy link
Collaborator

@suppermancool - We need to fix up the Gantt charts a bit:

Issue 1

The chart on the new challenge page is rendering differently than the edit challenge page. Ideally, these would be the same:

New challenge

Screen Shot 2020-04-27 at 12 26 11

Edit challenge

Screen Shot 2020-04-27 at 12 25 57

Issue 2

In terms of the phase duration, I got this clarification, so we can got with this assumption:

go now with the assumption that phase duration is hours

@jmgasper
Copy link
Collaborator Author

Contest https://www.topcoder.com/challenges/30123335 has been created for this ticket.

This is an automated message for ghostar via Topcoder X

@jmgasper
Copy link
Collaborator Author

Contest https://www.topcoder.com/challenges/30123335 has been updated - it has been assigned to diazz.

This is an automated message for ghostar via Topcoder X

@suppermancool
Copy link
Collaborator

suppermancool commented Apr 27, 2020

@jmgasper in the existing code if the backend return missing data or when create new challenge the frontend will calculate the challenge timelines locally.
For this i will:

  • Hide the timeline if the backend return broken phase.
  • In create new challenge i will hide the timeline until getting the response of first request of creating new draft challenge.

is this ok?

@jmgasper
Copy link
Collaborator Author

Yep, that sounds good, thanks

suppermancool added a commit to suppermancool/topcoder-platform-challenge-engine-ui that referenced this issue Apr 27, 2020
@suppermancool
Copy link
Collaborator

@jmgasper done in #180. i removed all local calculation for timeline, the timeline should come from backend now

@jmgasper
Copy link
Collaborator Author

@suppermancool - I don't see issue 2 address - this still seems to be in seconds.

@suppermancool
Copy link
Collaborator

@jmgasper do you have any challenge that have duration?

@jmgasper
Copy link
Collaborator Author

@suppermancool - I'm investigating. I'll get back to you.

suppermancool added a commit to suppermancool/topcoder-platform-challenge-engine-ui that referenced this issue Apr 27, 2020
@suppermancool
Copy link
Collaborator

suppermancool commented Apr 27, 2020

@jmgasper done in #182
We only use duration for calculating the Percent done:

Screen Shot 2020-04-27 at 14 43 46

The duration you see in that popup = Phase.scheduledEndDate - Phase.scheduledStartDate

jmgasper added a commit that referenced this issue Apr 27, 2020
@jmgasper
Copy link
Collaborator Author

@suppermancool - Thanks. I think that we have to do something here, but I'm not exactly sure what. I'm attempting to get clarification from the challenge API side.

@jmgasper
Copy link
Collaborator Author

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30123335

This is an automated message for ghostar via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants