diff --git a/src/common/challenge-helper.js b/src/common/challenge-helper.js index 81764aeb..6ee91781 100644 --- a/src/common/challenge-helper.js +++ b/src/common/challenge-helper.js @@ -119,7 +119,7 @@ class ChallengeHelper { // check groups authorization if (challenge.groups && challenge.groups.length > 0) { if (currentUser.isMachine || hasAdminRole(currentUser)) { - await validateGroups(challenge.groups); + await this.validateGroups(challenge.groups); } else { await helper.ensureAccessibleByGroupsAccess(currentUser, challenge); } @@ -145,7 +145,7 @@ class ChallengeHelper { // check groups access to be updated group values if (data.groups && data.groups.length > 0) { if (currentUser.isMachine || hasAdminRole(currentUser)) { - await validateGroups(data.groups); + await this.validateGroups(data.groups); } else { await ensureAcessibilityToModifiedGroups(currentUser, data, challenge); } diff --git a/src/services/ChallengeService.js b/src/services/ChallengeService.js index 4b1e9e2d..469d8806 100644 --- a/src/services/ChallengeService.js +++ b/src/services/ChallengeService.js @@ -36,7 +36,6 @@ const { ChallengeDomain } = require("@topcoder-framework/domain-challenge"); const { hasAdminRole } = require("../common/role-helper"); const { - validateChallengeUpdateRequest, enrichChallengeForResponse, sanitizeRepeatedFieldsInUpdateRequest, convertPrizeSetValuesToCents, @@ -1491,7 +1490,7 @@ async function updateChallenge(currentUser, challengeId, data) { const challengeResources = await helper.getChallengeResources(challengeId); - await validateChallengeUpdateRequest(currentUser, challenge, data, challengeResources); + await challengeHelper.validateChallengeUpdateRequest(currentUser, challenge, data, challengeResources); validateTask(currentUser, challenge, data, challengeResources); let sendActivationEmail = false;