From 54d2d538638f2a2d750a7ebb7f511af7776d0078 Mon Sep 17 00:00:00 2001 From: vikasrohit Date: Tue, 22 Sep 2020 18:15:46 +0530 Subject: [PATCH] Should read from payload Should read `task.memberId` from payload instead of the existing challenge value as reading it from existing values is preventing us from changing the assigned member. --- src/services/ChallengeService.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/services/ChallengeService.js b/src/services/ChallengeService.js index da76ce89..fd2ea7c3 100644 --- a/src/services/ChallengeService.js +++ b/src/services/ChallengeService.js @@ -1425,11 +1425,11 @@ async function update (currentUser, challengeId, data, userToken, isFull) { const { track, type } = await validateChallengeData(_.pick(challenge, ['trackId', 'typeId'])) if (_.get(type, 'isTask')) { - if (!_.isEmpty(_.get(challenge, 'task.memberId'))) { + if (!_.isEmpty(_.get(data, 'task.memberId'))) { const challengeResources = await helper.getChallengeResources(challengeId) const registrants = _.filter(challengeResources, r => r.roleId === config.SUBMITTER_ROLE_ID) - if (!_.find(registrants, r => _.toString(r.memberId) === _.toString(_.get(challenge, 'task.memberId')))) { - throw new errors.BadRequestError(`Member ${_.get(challenge, 'task.memberId')} is not a submitter resource of challenge ${challengeId}`) + if (!_.find(registrants, r => _.toString(r.memberId) === _.toString(_.get(data, 'task.memberId')))) { + throw new errors.BadRequestError(`Member ${_.get(data, 'task.memberId')} is not a submitter resource of challenge ${challengeId}`) } } }