-
Notifications
You must be signed in to change notification settings - Fork 52
When creating multiple attachments in parallel, only one is actually created #348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
PR #361 |
Deployed on dev, tested, works. cc @rootelement |
@ThomasKranitsas just to clarify. The initial issue which was described in this issue still persists, if I create attachments one by one, they disappear after https://monosnap.com/file/s3fjU3J3d3d3UeS6pA3aeyT2A5aJED After creating a demo, I've checked the PR and understood that returning the array is intentional, so I would try updating UI to use one call with an array to overcome this issue. |
@maxceem that's the only way to overcome this issue. What you're talking about is the same as making multiple PUT requests at the same time. The latest one will overwrite the rest. With the latest updates, as you correctly understood, you can make one request to create multiple attachments |
@rootelement when we are planning to move this to production? Attachments feature was broken on production in WM, so I am hiding that for now and would enable it again once we have these changes in production. |
Follow up from topcoder-platform/work-manager#917 (comment)
In Work Manager, we support uploading multiple attachments at once.
POST /challenges/:id/attachments
requests in parallel and all of them are successfulGET /challenge/:id
returns only one attachmentSee demo video https://monosnap.com/file/mVqe0igPbDIa68bUepKwRujaTU0mQN
Example challenge
29d3d66f-d87f-402f-882f-258235ac7a6f
on DEV.The text was updated successfully, but these errors were encountered: