validation updates

Author: ThomasKranitsas

src/common/challenge-helper.js

@@ -117,6 +117,11 @@ class ChallengeHelper {
       await ensureAcessibilityToModifiedGroups(currentUser, data, challenge);
     }
 
+    // Ensure descriptionFormat is either 'markdown' or 'html'
+    if (data.descriptionFormat && !_.includes(["markdown", "html"], data.descriptionFormat)) {
+      throw new errors.BadRequestError("The property 'descriptionFormat' must be either 'markdown' or 'html'");
+    }
+
     // Ensure unchangeable fields are not changed
     if (
       _.get(challenge, "legacy.track") &&

src/services/ChallengeService.js

@@ -1515,6 +1515,13 @@ async function updateChallenge(currentUser, challengeId, data) {
     _.set(data, "billing.markup", markup || 0);
   }
 
+  // Make sure the user cannot change the direct project ID
+  if (data.legacy && data.legacy.directProjectId) {
+    const { directProjectId } = await projectHelper.getProject(projectId, currentUser);
+
+    _.set(challenge, "legacy.directProjectId", directProjectId);
+  }
+
   /* BEGIN self-service stuffs */
 
   // TODO: At some point in the future this should be moved to a Self-Service Challenge Helper