Merge pull request #604 from topcoder-platform/fix/canceled-phases

close registration, submission, checkpoint submission after cancellation

Author: ThomasKranitsas

src/common/phase-helper.js

@@ -170,6 +170,17 @@ class ChallengePhaseHelper {
     return updatedPhases;
   }
 
+  handlePhasesAfterCancelling(phases) {
+    return _.map(phases, (phase) => {
+      if (_.includes(["Registration", "Submission", "Checkpoint Submission"], phase.name)) {
+        phase.isOpen = false;
+        if (!_.isUndefined(phase.actualStartDate)) {
+          phase.actualEndDate = moment().toDate().toISOString();
+        }
+      }
+    });
+  }
+
   async validatePhases(phases) {
     if (!phases || phases.length === 0) {
       return;

src/services/ChallengeService.js

@@ -1594,6 +1594,7 @@ async function updateChallenge(currentUser, challengeId, data) {
   /* END self-service stuffs */
 
   let isChallengeBeingActivated = false;
+  let isChallengeBeingCancelled = false;
   if (data.status) {
     if (data.status === constants.challengeStatuses.Active) {
       if (
@@ -1619,6 +1620,20 @@ async function updateChallenge(currentUser, challengeId, data) {
       }
     }
 
+    if (_.includes([
+      constants.challengeStatuses.Cancelled,
+      constants.challengeStatuses.CancelledRequirementsInfeasible,
+      constants.challengeStatuses.CancelledPaymentFailed,
+      constants.challengeStatuses.CancelledFailedReview,
+      constants.challengeStatuses.CancelledFailedScreening,
+      constants.challengeStatuses.CancelledZeroSubmissions,
+      constants.challengeStatuses.CancelledWinnerUnresponsive,
+      constants.challengeStatuses.CancelledClientRequest,
+      constants.challengeStatuses.CancelledZeroRegistrations,
+    ], data.status)) {
+      isChallengeBeingCancelled = true;
+    }
+
     if (
       data.status === constants.challengeStatuses.CancelledRequirementsInfeasible ||
       data.status === constants.challengeStatuses.CancelledPaymentFailed
@@ -1723,9 +1738,9 @@ async function updateChallenge(currentUser, challengeId, data) {
 
   let phasesUpdated = false;
   if (
-    (data.phases && data.phases.length > 0) ||
+    ((data.phases && data.phases.length > 0) ||
     isChallengeBeingActivated ||
-    timelineTemplateChanged
+    timelineTemplateChanged) && !isChallengeBeingCancelled
   ) {
     if (
       challenge.status === constants.challengeStatuses.Completed ||
@@ -1754,6 +1769,10 @@ async function updateChallenge(currentUser, challengeId, data) {
     phasesUpdated = true;
     data.phases = newPhases;
   }
+  if (isChallengeBeingCancelled) {
+    data.phases = await phaseHelper.handlePhasesAfterCancelling(challenge.phases);
+    phasesUpdated = true;
+  }
   if (phasesUpdated || data.startDate) {
     data.startDate = convertToISOString(_.min(_.map(data.phases, "scheduledStartDate")));
   }