fix: only allow Active, Draft challenges to be extended

rakibansary · rakibansary · commit 82898c8cd478 · 2023-01-27T19:21:16.000+06:00
diff --git a/src/services/ChallengeService.js b/src/services/ChallengeService.js
@@ -1524,7 +1524,7 @@ async function update (currentUser, challengeId, data, isFull) {
     }
   }
 
-  if (challenge.status !== constants.challengeStatuses.Completed && (data.phases || data.startDate)) {
+  if ((challenge.status === constants.challengeStatuses.Active || challenge.status === constants.challengeStatuses.Draft) && (data.phases || data.startDate)) {
     if (data.phases && data.phases.length > 0) {
       for (let i = 0; i < challenge.phases.length; i += 1) {
         const updatedPhaseInfo = _.find(data.phases, p => p.phaseId === challenge.phases[i].phaseId)

Original file line number	Diff line number	Diff line change
`@@ -1524,7 +1524,7 @@ async function update (currentUser, challengeId, data, isFull) {`
`1524`	`1524`	`}`
`1525`	`1525`	`}`
`1526`	`1526`
`1527`		`- if (challenge.status !== constants.challengeStatuses.Completed && (data.phases \|\| data.startDate)) {`
	`1527`	`+ if ((challenge.status === constants.challengeStatuses.Active \|\| challenge.status === constants.challengeStatuses.Draft) && (data.phases \|\| data.startDate)) {`
`1528`	`1528`	`if (data.phases && data.phases.length > 0) {`
`1529`	`1529`	`for (let i = 0; i < challenge.phases.length; i += 1) {`
`1530`	`1530`	`const updatedPhaseInfo = _.find(data.phases, p => p.phaseId === challenge.phases[i].phaseId)`