Merge pull request #156 from topcoder-platform/issue-155

Consider missing terms property as empty

Author: rootelement

src/common/helper.js

@@ -593,7 +593,7 @@ async function getProjectDefaultTerms (projectId) {
  *
  * @param {Array<Object>} terms The array of terms {id, roleId} to retrieve from terms API
  */
-async function validateChallengeTerms (terms) {
+async function validateChallengeTerms (terms = []) {
   const listOfTerms = []
   const token = await getM2MToken()
   for (let term of terms) {

src/services/ChallengeService.js

@@ -466,7 +466,7 @@ async function createChallenge (currentUser, challenge, userToken) {
   // challenge.terms = await helper.validateChallengeTerms(_.union(projectTerms, challenge.terms))
   // TODO - challenge terms returned from projects api don't have a role associated
   // this will need to be updated to associate project terms with a roleId
-  challenge.terms = await helper.validateChallengeTerms(challenge.terms)
+  challenge.terms = await helper.validateChallengeTerms(challenge.terms || [])
 
   if (challenge.phases && challenge.phases.length > 0) {
     challenge.endDate = helper.calculateChallengeEndDate(challenge)