Skip to content

Commit 4005951

Browse files
committed
fix: post-mortem phase
* post-mortem phase should be "scheduled" if submission phase is opened * because of extension
1 parent 0c2b009 commit 4005951

File tree

1 file changed

+11
-5
lines changed

1 file changed

+11
-5
lines changed

src/common/phase-helper.js

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,8 @@ class ChallengePhaseHelper {
6969
return 0
7070
})
7171

72+
let isSubmissionPhaseOpen = false
73+
7274
for (let p of phases) {
7375
const predecessor = timelineTemplateMap.get(p.predecessor)
7476

@@ -109,19 +111,23 @@ class ChallengePhaseHelper {
109111
}
110112
p.isOpen = moment().isBetween(p.scheduledStartDate, p.scheduledEndDate)
111113
if (p.isOpen) {
114+
if (p.name === 'Submission') {
115+
isSubmissionPhaseOpen = true
116+
}
112117
delete p.actualEndDate
113118
}
114119

115120
if (moment(p.scheduledStartDate).isAfter(moment())) {
116121
delete p.actualStartDate
117122
delete p.actualEndDate
118123
}
119-
}
120124

121-
// if submission phase is open, remove post-mortem phase
122-
// if (isSubmissionPhaseOpen && postMortemPhaseIndex > -1) {
123-
// phases.splice(postMortemPhaseIndex, 1)
124-
// }
125+
if (p.name === 'Post-Mortem' && isSubmissionPhaseOpen) {
126+
delete p.actualStartDate
127+
delete p.actualEndDate
128+
p.isOpen = false
129+
}
130+
}
125131

126132
// phases.sort((a, b) => moment(a.scheduledStartDate).isAfter(b.scheduledStartDate))
127133
}

0 commit comments

Comments
 (0)