fix: skip check

Rakib Ansary · Rakib Ansary · commit 3ae3ad4d3b9e · 2024-04-10T03:08:03.000+06:00
Signed-off-by: Rakib Ansary &lt;rakibansary@Rakibs-MacBook-Pro.local&gt;
diff --git a/config/default.js b/config/default.js
@@ -131,5 +131,5 @@ module.exports = {
   GRPC_ACL_SERVER_HOST: process.env.GRPC_ACL_SERVER_HOST || "localhost",
   GRPC_ACL_SERVER_PORT: process.env.GRPC_ACL_SERVER_PORT || 8889,
 
-  SKIP_PROJECT_ID_BY_TIMLINE_TEMPLATE_ID: ['517e76b0-8824-4e72-9b48-a1ebde1793a8']
+  SKIP_PROJECT_ID_BY_TIMLINE_TEMPLATE_ID: process.env.SKIP_PROJECT_ID_BY_TIMLINE_TEMPLATE_ID || '517e76b0-8824-4e72-9b48-a1ebde1793a8'
 };
diff --git a/src/common/challenge-helper.js b/src/common/challenge-helper.js
@@ -530,13 +530,9 @@ class ChallengeHelper {
   }
 
   isProjectIdRequired(timelineTemplateId) {
-    if (
-      _.isNull(timelineTemplateId) ||
-      _.isUndefined(timelineTemplateId) ||
-      !_.includes(config.SKIP_PROJECT_ID_BY_TIMLINE_TEMPLATE_ID, timelineTemplateId)
-    )
-      return true;
-    return false;
+    const template = _.get(config, "SKIP_PROJECT_ID_BY_TIMLINE_TEMPLATE_ID", '517e76b0-8824-4e72-9b48-a1ebde1793a8');
+
+    return template !== timelineTemplateId;
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -530,13 +530,9 @@ class ChallengeHelper {`
`530`	`530`	`}`
`531`	`531`
`532`	`532`	`isProjectIdRequired(timelineTemplateId) {`
`533`		`- if (`
`534`		`- _.isNull(timelineTemplateId) \|\|`
`535`		`- _.isUndefined(timelineTemplateId) \|\|`
`536`		`- !_.includes(config.SKIP_PROJECT_ID_BY_TIMLINE_TEMPLATE_ID, timelineTemplateId)`
`537`		`- )`
`538`		`- return true;`
`539`		`- return false;`
	`533`	`+ const template = _.get(config, "SKIP_PROJECT_ID_BY_TIMLINE_TEMPLATE_ID", '517e76b0-8824-4e72-9b48-a1ebde1793a8');`
	`534`	`+`
	`535`	`+ return template !== timelineTemplateId;`
`540`	`536`	`}`
`541`	`537`	`}`
`542`	`538`