Skip to content

Commit 169d2bf

Browse files
author
James Cori
committed
Changing order of Operations
1 parent 3f49e1a commit 169d2bf

File tree

1 file changed

+11
-10
lines changed

1 file changed

+11
-10
lines changed

src/services/ChallengeService.js

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -850,8 +850,14 @@ async function createChallenge (currentUser, challenge, userToken) {
850850
ret.type = type.name
851851
}
852852

853-
// post bus event
854-
await helper.postBusEvent(constants.Topics.ChallengeCreated, ret)
853+
// Create in ES
854+
await esClient.create({
855+
index: config.get('ES.ES_INDEX'),
856+
type: config.get('ES.ES_TYPE'),
857+
refresh: config.get('ES.ES_REFRESH'),
858+
id: ret.id,
859+
body: ret
860+
})
855861

856862
// if created by a user, add user as a manager
857863
if (currentUser.handle) {
@@ -861,14 +867,9 @@ async function createChallenge (currentUser, challenge, userToken) {
861867
logger.debug(`Not adding manager ${currentUser.sub} ${JSON.stringify(currentUser)}`)
862868
}
863869

864-
// Create in ES
865-
await esClient.create({
866-
index: config.get('ES.ES_INDEX'),
867-
type: config.get('ES.ES_TYPE'),
868-
refresh: config.get('ES.ES_REFRESH'),
869-
id: ret.id,
870-
body: ret
871-
})
870+
// post bus event
871+
await helper.postBusEvent(constants.Topics.ChallengeCreated, ret)
872+
872873
return ret
873874
}
874875

0 commit comments

Comments
 (0)