Skip to content

Commit fe117ec

Browse files
committed
fix: make suggestions case insensetive
1 parent a47cd2b commit fe117ec

File tree

3 files changed

+9
-6
lines changed

3 files changed

+9
-6
lines changed

src/app/devices/devices.edit.controller.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -46,21 +46,22 @@ module.controller('devices.EditDeviceController', ['$scope', '$rootScope', '$log
4646
// manufacturer autocomplete
4747
$scope.oldType = '';
4848
$scope.getManufacturers = function (viewValue) {
49+
var loweCaseValue = viewValue.toLowerCase()
4950
if($scope.device.type == ''){
5051
return
5152
}
5253
// use the 'manufacturers' obtained early if the type is not changed to avoid frequent request
5354
if($scope.oldType == $scope.device.type){
5455
return $scope.manufacturers.filter(function(manufacturer) {
55-
return manufacturer.indexOf(viewValue) != -1;
56+
return manufacturer.toLowerCase().indexOf(loweCaseValue) != -1;
5657
});
5758
}
5859
return DeviceService.getManufacturers($scope.device.type).then(
5960
function(manufacturers) {
6061
$scope.manufacturers = manufacturers;
6162
$scope.oldType = $scope.device.type;
6263
return $scope.manufacturers.filter(function(manufacturer) {
63-
return manufacturer.indexOf(viewValue) != -1;
64+
return manufacturer.toLowerCase().indexOf(loweCaseValue) != -1;
6465
});
6566
});
6667
}

src/app/devices/devices.list.controller.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -40,21 +40,22 @@ module.controller('devices.DevicesListController', ['$scope', '$rootScope', '$lo
4040
// manufacturer autocomplete
4141
$scope.oldType = '';
4242
$scope.getManufacturers = function (viewValue) {
43+
var loweCaseValue = viewValue.toLowerCase()
4344
if($scope.formSearch.criteria.type == ''){
4445
return
4546
}
4647
// use the 'manufacturers' obtained early if the type is not changed to avoid frequent request
4748
if($scope.oldType == $scope.formSearch.criteria.type){
4849
return $scope.manufacturers.filter(function(manufacturer) {
49-
return manufacturer.indexOf(viewValue) != -1;
50+
return manufacturer.toLowerCase().indexOf(loweCaseValue) != -1;
5051
});
5152
}
5253
return DeviceService.getManufacturers($scope.formSearch.criteria.type).then(
5354
function(manufacturers) {
5455
$scope.manufacturers = manufacturers;
5556
$scope.oldType = $scope.formSearch.criteria.type;
5657
return $scope.manufacturers.filter(function(manufacturer) {
57-
return manufacturer.indexOf(viewValue) != -1;
58+
return manufacturer.toLowerCase().indexOf(loweCaseValue) != -1;
5859
});
5960
});
6061
}

src/app/devices/devices.new.controller.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -36,21 +36,22 @@ module.controller('devices.NewDeviceController', ['$scope', '$rootScope', '$log'
3636
// manufacturer autocomplete
3737
$scope.oldType = '';
3838
$scope.getManufacturers = function (viewValue) {
39+
var loweCaseValue = viewValue.toLowerCase()
3940
if($scope.device.type == ''){
4041
return
4142
}
4243
// use the 'manufacturers' obtained early if the type is not changed to avoid frequent request
4344
if($scope.oldType == $scope.device.type){
4445
return $scope.manufacturers.filter(function(manufacturer) {
45-
return manufacturer.indexOf(viewValue) != -1;
46+
return manufacturer.toLowerCase().indexOf(loweCaseValue) != -1;
4647
});
4748
}
4849
return DeviceService.getManufacturers($scope.device.type).then(
4950
function(manufacturers) {
5051
$scope.manufacturers = manufacturers;
5152
$scope.oldType = $scope.device.type;
5253
return $scope.manufacturers.filter(function(manufacturer) {
53-
return manufacturer.indexOf(viewValue) != -1;
54+
return manufacturer.toLowerCase().indexOf(loweCaseValue) != -1;
5455
});
5556
});
5657
}

0 commit comments

Comments
 (0)