Skip to content
This repository was archived by the owner on Mar 12, 2025. It is now read-only.

Commit 41cbd84

Browse files
author
Vikas Agarwal
committed
fix: Updated m2m permissions to be logically related to skill not to the projects
1 parent 36d0772 commit 41cbd84

File tree

3 files changed

+50
-48
lines changed

3 files changed

+50
-48
lines changed

‎docs/permissions.html

Lines changed: 24 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -97,9 +97,8 @@ <h2 class="anchor-container">
9797
</div>
9898

9999
<div>
100-
<span class="badge badge-dark" title="Allowed Topcoder Role">all:connect_project</span>
101-
<span class="badge badge-dark" title="Allowed Topcoder Role">all:projects</span>
102-
<span class="badge badge-dark" title="Allowed Topcoder Role">write:projects</span>
100+
<span class="badge badge-dark" title="Allowed Topcoder Role">create:skill</span>
101+
<span class="badge badge-dark" title="Allowed Topcoder Role">all:skill</span>
103102
</div>
104103
</div>
105104
</div>
@@ -127,9 +126,8 @@ <h2 class="anchor-container">
127126
</div>
128127

129128
<div>
130-
<span class="badge badge-dark" title="Allowed Topcoder Role">all:connect_project</span>
131-
<span class="badge badge-dark" title="Allowed Topcoder Role">all:projects</span>
132-
<span class="badge badge-dark" title="Allowed Topcoder Role">write:projects</span>
129+
<span class="badge badge-dark" title="Allowed Topcoder Role">update:skill</span>
130+
<span class="badge badge-dark" title="Allowed Topcoder Role">all:skill</span>
133131
</div>
134132
</div>
135133
</div>
@@ -157,9 +155,8 @@ <h2 class="anchor-container">
157155
</div>
158156

159157
<div>
160-
<span class="badge badge-dark" title="Allowed Topcoder Role">all:connect_project</span>
161-
<span class="badge badge-dark" title="Allowed Topcoder Role">all:projects</span>
162-
<span class="badge badge-dark" title="Allowed Topcoder Role">write:projects</span>
158+
<span class="badge badge-dark" title="Allowed Topcoder Role">delete:skill</span>
159+
<span class="badge badge-dark" title="Allowed Topcoder Role">all:skill</span>
163160
</div>
164161
</div>
165162
</div>
@@ -194,9 +191,8 @@ <h2 class="anchor-container">
194191
</div>
195192

196193
<div>
197-
<span class="badge badge-dark" title="Allowed Topcoder Role">all:connect_project</span>
198-
<span class="badge badge-dark" title="Allowed Topcoder Role">all:projects</span>
199-
<span class="badge badge-dark" title="Allowed Topcoder Role">write:projects</span>
194+
<span class="badge badge-dark" title="Allowed Topcoder Role">create:skill</span>
195+
<span class="badge badge-dark" title="Allowed Topcoder Role">all:skill</span>
200196
</div>
201197
</div>
202198
</div>
@@ -224,9 +220,8 @@ <h2 class="anchor-container">
224220
</div>
225221

226222
<div>
227-
<span class="badge badge-dark" title="Allowed Topcoder Role">all:connect_project</span>
228-
<span class="badge badge-dark" title="Allowed Topcoder Role">all:projects</span>
229-
<span class="badge badge-dark" title="Allowed Topcoder Role">write:projects</span>
223+
<span class="badge badge-dark" title="Allowed Topcoder Role">update:skill</span>
224+
<span class="badge badge-dark" title="Allowed Topcoder Role">all:skill</span>
230225
</div>
231226
</div>
232227
</div>
@@ -254,9 +249,8 @@ <h2 class="anchor-container">
254249
</div>
255250

256251
<div>
257-
<span class="badge badge-dark" title="Allowed Topcoder Role">all:connect_project</span>
258-
<span class="badge badge-dark" title="Allowed Topcoder Role">all:projects</span>
259-
<span class="badge badge-dark" title="Allowed Topcoder Role">write:projects</span>
252+
<span class="badge badge-dark" title="Allowed Topcoder Role">delete:skill</span>
253+
<span class="badge badge-dark" title="Allowed Topcoder Role">all:skill</span>
260254
</div>
261255
</div>
262256
</div>
@@ -291,9 +285,8 @@ <h2 class="anchor-container">
291285
</div>
292286

293287
<div>
294-
<span class="badge badge-dark" title="Allowed Topcoder Role">all:connect_project</span>
295-
<span class="badge badge-dark" title="Allowed Topcoder Role">all:projects</span>
296-
<span class="badge badge-dark" title="Allowed Topcoder Role">write:projects</span>
288+
<span class="badge badge-dark" title="Allowed Topcoder Role">create:taxonomy</span>
289+
<span class="badge badge-dark" title="Allowed Topcoder Role">all:taxonomy</span>
297290
</div>
298291
</div>
299292
</div>
@@ -321,9 +314,8 @@ <h2 class="anchor-container">
321314
</div>
322315

323316
<div>
324-
<span class="badge badge-dark" title="Allowed Topcoder Role">all:connect_project</span>
325-
<span class="badge badge-dark" title="Allowed Topcoder Role">all:projects</span>
326-
<span class="badge badge-dark" title="Allowed Topcoder Role">write:projects</span>
317+
<span class="badge badge-dark" title="Allowed Topcoder Role">update:taxonomy</span>
318+
<span class="badge badge-dark" title="Allowed Topcoder Role">all:taxonomy</span>
327319
</div>
328320
</div>
329321
</div>
@@ -351,9 +343,8 @@ <h2 class="anchor-container">
351343
</div>
352344

353345
<div>
354-
<span class="badge badge-dark" title="Allowed Topcoder Role">all:connect_project</span>
355-
<span class="badge badge-dark" title="Allowed Topcoder Role">all:projects</span>
356-
<span class="badge badge-dark" title="Allowed Topcoder Role">write:projects</span>
346+
<span class="badge badge-dark" title="Allowed Topcoder Role">delete:taxonomy</span>
347+
<span class="badge badge-dark" title="Allowed Topcoder Role">all:taxonomy</span>
357348
</div>
358349
</div>
359350
</div>
@@ -388,9 +379,8 @@ <h2 class="anchor-container">
388379
</div>
389380

390381
<div>
391-
<span class="badge badge-dark" title="Allowed Topcoder Role">all:connect_project</span>
392-
<span class="badge badge-dark" title="Allowed Topcoder Role">all:projects</span>
393-
<span class="badge badge-dark" title="Allowed Topcoder Role">write:projects</span>
382+
<span class="badge badge-dark" title="Allowed Topcoder Role">create:taxonomy</span>
383+
<span class="badge badge-dark" title="Allowed Topcoder Role">all:taxonomy</span>
394384
</div>
395385
</div>
396386
</div>
@@ -418,9 +408,8 @@ <h2 class="anchor-container">
418408
</div>
419409

420410
<div>
421-
<span class="badge badge-dark" title="Allowed Topcoder Role">all:connect_project</span>
422-
<span class="badge badge-dark" title="Allowed Topcoder Role">all:projects</span>
423-
<span class="badge badge-dark" title="Allowed Topcoder Role">write:projects</span>
411+
<span class="badge badge-dark" title="Allowed Topcoder Role">update:taxonomy</span>
412+
<span class="badge badge-dark" title="Allowed Topcoder Role">all:taxonomy</span>
424413
</div>
425414
</div>
426415
</div>
@@ -448,9 +437,8 @@ <h2 class="anchor-container">
448437
</div>
449438

450439
<div>
451-
<span class="badge badge-dark" title="Allowed Topcoder Role">all:connect_project</span>
452-
<span class="badge badge-dark" title="Allowed Topcoder Role">all:projects</span>
453-
<span class="badge badge-dark" title="Allowed Topcoder Role">write:projects</span>
440+
<span class="badge badge-dark" title="Allowed Topcoder Role">delete:taxonomy</span>
441+
<span class="badge badge-dark" title="Allowed Topcoder Role">all:taxonomy</span>
454442
</div>
455443
</div>
456444
</div>

‎src/constants.js

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,20 @@ const M2M_SCOPES = {
4040
PROJECTS: {
4141
ALL: 'all:projects',
4242
WRITE: 'write:projects'
43+
},
44+
SKILLS: {
45+
ALL: 'all:skill',
46+
CREATE: 'create:skill',
47+
READ: 'read:skill',
48+
UPDATE: 'update:skill',
49+
DELETE: 'delete:skill'
50+
},
51+
TAXONOMIES: {
52+
ALL: 'all:taxonomy',
53+
CREATE: 'create:taxonomy',
54+
READ: 'read:taxonomy',
55+
UPDATE: 'update:taxonomy',
56+
DELETE: 'delete:taxonomy'
4357
}
4458
}
4559

‎src/permissions/constants.js

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ const PERMISSION = {
7272
group: 'Skill'
7373
},
7474
topcoderRoles: TOPCODER_ROLES_MANAGERS_AND_ADMINS,
75-
scopes: SCOPES_PROJECTS_WRITE
75+
scopes: [M2M_SCOPES.SKILLS.CREATE, M2M_SCOPES.SKILLS.ALL]
7676
},
7777

7878
UPDATE_SKILL: {
@@ -81,7 +81,7 @@ const PERMISSION = {
8181
group: 'Skill'
8282
},
8383
topcoderRoles: TOPCODER_ROLES_MANAGERS_AND_ADMINS,
84-
scopes: SCOPES_PROJECTS_WRITE
84+
scopes: [M2M_SCOPES.SKILLS.UPDATE, M2M_SCOPES.SKILLS.ALL]
8585
},
8686

8787
DELETE_SKILL: {
@@ -90,7 +90,7 @@ const PERMISSION = {
9090
group: 'Skill'
9191
},
9292
topcoderRoles: TOPCODER_ROLES_MANAGERS_AND_ADMINS,
93-
scopes: SCOPES_PROJECTS_WRITE
93+
scopes: [M2M_SCOPES.SKILLS.DELETE, M2M_SCOPES.SKILLS.ALL]
9494
},
9595

9696
/*
@@ -103,7 +103,7 @@ const PERMISSION = {
103103
description: 'Add metadata fields in a skill'
104104
},
105105
topcoderRoles: TOPCODER_ROLES_MANAGERS_AND_ADMINS,
106-
scopes: SCOPES_PROJECTS_WRITE
106+
scopes: [M2M_SCOPES.SKILLS.CREATE, M2M_SCOPES.SKILLS.ALL]
107107
},
108108

109109
UPDATE_SKILL_METADATA: {
@@ -113,7 +113,7 @@ const PERMISSION = {
113113
description: 'Update Metadata fields from a skill'
114114
},
115115
topcoderRoles: TOPCODER_ROLES_MANAGERS_AND_ADMINS,
116-
scopes: SCOPES_PROJECTS_WRITE
116+
scopes: [M2M_SCOPES.SKILLS.UPDATE, M2M_SCOPES.SKILLS.ALL]
117117
},
118118

119119
DELETE_SKILL_METADATA: {
@@ -123,7 +123,7 @@ const PERMISSION = {
123123
description: 'Delete Metadata fields from a skill'
124124
},
125125
topcoderRoles: TOPCODER_ROLES_MANAGERS_AND_ADMINS,
126-
scopes: SCOPES_PROJECTS_WRITE
126+
scopes: [M2M_SCOPES.SKILLS.DELETE, M2M_SCOPES.SKILLS.ALL]
127127
},
128128

129129
/*
@@ -135,7 +135,7 @@ const PERMISSION = {
135135
group: 'Taxonomy'
136136
},
137137
topcoderRoles: TOPCODER_ROLES_MANAGERS_AND_ADMINS,
138-
scopes: SCOPES_PROJECTS_WRITE
138+
scopes: [M2M_SCOPES.TAXONOMIES.CREATE, M2M_SCOPES.TAXONOMIES.ALL]
139139
},
140140

141141
UPDATE_TAXONOMY: {
@@ -144,7 +144,7 @@ const PERMISSION = {
144144
group: 'Taxonomy'
145145
},
146146
topcoderRoles: TOPCODER_ROLES_MANAGERS_AND_ADMINS,
147-
scopes: SCOPES_PROJECTS_WRITE
147+
scopes: [M2M_SCOPES.TAXONOMIES.UPDATE, M2M_SCOPES.TAXONOMIES.ALL]
148148
},
149149

150150
DELETE_TAXONOMY: {
@@ -153,7 +153,7 @@ const PERMISSION = {
153153
group: 'Taxonomy'
154154
},
155155
topcoderRoles: TOPCODER_ROLES_MANAGERS_AND_ADMINS,
156-
scopes: SCOPES_PROJECTS_WRITE
156+
scopes: [M2M_SCOPES.TAXONOMIES.DELETE, M2M_SCOPES.TAXONOMIES.ALL]
157157
},
158158

159159
/*
@@ -166,7 +166,7 @@ const PERMISSION = {
166166
description: 'Add metadata fields in a taxonomy'
167167
},
168168
topcoderRoles: TOPCODER_ROLES_MANAGERS_AND_ADMINS,
169-
scopes: SCOPES_PROJECTS_WRITE
169+
scopes: [M2M_SCOPES.TAXONOMIES.CREATE, M2M_SCOPES.TAXONOMIES.ALL]
170170
},
171171

172172
UPDATE_TAXONOMY_METADATA: {
@@ -176,7 +176,7 @@ const PERMISSION = {
176176
description: 'Update Metadata fields from a taxonomy'
177177
},
178178
topcoderRoles: TOPCODER_ROLES_MANAGERS_AND_ADMINS,
179-
scopes: SCOPES_PROJECTS_WRITE
179+
scopes: [M2M_SCOPES.TAXONOMIES.UPDATE, M2M_SCOPES.TAXONOMIES.ALL]
180180
},
181181

182182
DELETE_TAXONOMY_METADATA: {
@@ -186,7 +186,7 @@ const PERMISSION = {
186186
description: 'Delete Metadata fields from a taxonomy'
187187
},
188188
topcoderRoles: TOPCODER_ROLES_MANAGERS_AND_ADMINS,
189-
scopes: SCOPES_PROJECTS_WRITE
189+
scopes: [M2M_SCOPES.TAXONOMIES.DELETE, M2M_SCOPES.TAXONOMIES.ALL]
190190
}
191191
}
192192

0 commit comments

Comments
 (0)