fix: values of query params might be encoded when having special characters

Some query params may have special characters thus got encoded client-side.
So I'm reverting code which uses "decodeURIComponent" to decode such query params.

TODO: we might replace custom logic for decoding **some** query params with an automatic mechanism to decode **all** query params.

Author: maxceem

src/routes/milestoneTemplates/list.js

@@ -14,7 +14,7 @@ module.exports = [
   permissions('milestoneTemplate.view'),
   (req, res, next) => {
     // Parse the sort query
-    let sort = req.query.sort ? req.query.sort : 'order';
+    let sort = req.query.sort ? decodeURIComponent(req.query.sort) : 'order';
     if (sort && sort.indexOf(' ') === -1) {
       sort += ' asc';
     }

src/routes/milestones/list.js

@@ -28,7 +28,7 @@ module.exports = [
   permissions('milestone.view'),
   (req, res, next) => {
     // Parse the sort query
-    let sort = req.query.sort ? req.query.sort : 'order';
+    let sort = req.query.sort ? decodeURIComponent(req.query.sort) : 'order';
     if (sort && sort.indexOf(' ') === -1) {
       sort += ' asc';
     }

src/routes/phases/list.js

@@ -20,8 +20,8 @@ module.exports = [
     const projectId = _.parseInt(req.params.projectId);
 
     // Parse the fields string to determine what fields are to be returned
-    let fields = req.query.fields ? req.query.fields.split(',') : PHASE_ATTRIBUTES;
-    let sort = req.query.sort ? req.query.sort : 'startDate';
+    let fields = req.query.fields ? decodeURIComponent(req.query.fields).split(',') : PHASE_ATTRIBUTES;
+    let sort = req.query.sort ? decodeURIComponent(req.query.sort) : 'startDate';
     if (sort && sort.indexOf(' ') === -1) {
       sort += ' asc';
     }

src/routes/projects/list.js

@@ -531,7 +531,7 @@ module.exports = [
     // handle filters
     let filters = _.omit(req.query, 'sort', 'perPage', 'page', 'fields');
 
-    let sort = req.query.sort ? req.query.sort : 'createdAt';
+    let sort = req.query.sort ? decodeURIComponent(req.query.sort) : 'createdAt';
     if (sort && sort.indexOf(' ') === -1) {
       sort += ' asc';
     }