#12 - Improve error messages

Author: callmekatootie

src/services/ProcessorService.js

@@ -144,8 +144,17 @@ async function createUserSkill (userId, skillProviderName, skillName, certifierI
     return
   }
   const skillProvider = await helper.getUbahnSingleRecord('/skillsProviders', { name: skillProviderName })
+
+  if (!skillProvider) {
+    throw Error(`Cannot find skill provider with name ${skillProviderName}`)
+  }
+
   const skill = await helper.getUbahnSingleRecord('/skills', { skillProviderId: skillProvider.id, name: skillName })
 
+  if (!skill) {
+    throw Error(`Cannot find skill with name ${skillName} under skill provider ${skillProviderName}`)
+  }
+
   // Does the skill already exist on the user?
   const existingSkill = await helper.getUbahnSingleRecord(`/users/${userId}/skills/${skill.id}`, {}, true)
 
@@ -174,6 +183,11 @@ async function createAchievement (userId, providerName, certifierId, certifiedDa
     return
   }
   const achievementsProvider = await helper.getUbahnSingleRecord('/achievementsProviders', { name: providerName })
+
+  if (!achievementsProvider) {
+    throw Error(`Cannot find achievement provider with name ${providerName}`)
+  }
+
   const existingAchievement = await helper.getUbahnSingleRecord(`/users/${userId}/achievements/${achievementsProvider.id}`, {}, true)
 
   if (!existingAchievement || !existingAchievement.id) {
@@ -201,7 +215,17 @@ async function createUserAttributes (userId, record) {
       return
     }
     const attributeGroup = await helper.getUbahnSingleRecord('/attributeGroups', { name: record[`attributeGroupName${i}`] })
+
+    if (!attributeGroup) {
+      throw Error(`Cannot find attribute group with name ${record[`attributeGroupName${i}`]}`)
+    }
+
     const attribute = await helper.getUbahnSingleRecord('/attributes', { attributeGroupId: attributeGroup.id, name: record[`attributeName${i}`] })
+
+    if (!attribute) {
+      throw Error(`Cannot find attribute with name ${record[`attributeName${i}`]} under attribute group wth name ${record[`attributeGroupName${i}`]}`)
+    }
+
     const value = _.toString(record[`attributeValue${i}`])
     const existingAttribute = await helper.getUbahnSingleRecord(`/users/${userId}/attributes/${attribute.id}`, {}, true)