Prevent joi from polluting log with error messages about kafka message it should be ignoring. Also fix error where checking if record exists would throw errors

Author: callmekatootie

src/app.js

@@ -42,6 +42,12 @@ const dataHandler = (messageSet, topic, partition) => Promise.each(messageSet, a
     return
   }
 
+  if (messageJSON.payload.resource !== 'upload') {
+    logger.info(`The message payload resource ${messageJSON.payload.resource} is not "upload". Ignoring message.`)
+
+    return
+  }
+
   try {
     await ProcessorService.processCreate(messageJSON)
 

src/common/helper.js

@@ -105,7 +105,19 @@ async function getUbahnSingleRecord (path, params, isOptionRecord) {
 
   logger.debug(`request GET ${path} by params: ${JSON.stringify(params)}`)
   try {
-    const res = await axios.get(`${config.UBAHN_API_URL}${path}`, { headers: { Authorization: `Bearer ${token}` }, params })
+    const res = await axios.get(`${config.UBAHN_API_URL}${path}`, {
+      headers: { Authorization: `Bearer ${token}` },
+      params,
+      validateStatus: (status) => {
+        if (isOptionRecord && status === 404) {
+          // If record is not found, it is not an error in scenario where we are checking
+          // if record exists or not
+          return true
+        }
+
+        return false
+      }
+    })
     if (_.isArray(res.data)) {
       if (res.data.length === 1) {
         return res.data[0]

src/services/ProcessorService.js

@@ -213,13 +213,7 @@ async function processCreateRecord (record, failedRecord) {
  * @returns {Promise}
  */
 async function processCreate (message) {
-  const { resource, status } = message.payload
-
-  if (resource !== 'upload') {
-    logger.info('Ignoring this message since resource is not `upload`')
-
-    return
-  }
+  const { status } = message.payload
 
   if (status === 'pending') {
     try {