Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

Commit 1bc1bd7

Browse files
Remove wrong use of useEffect
1 parent 0cde616 commit 1bc1bd7

File tree

2 files changed

+7
-19
lines changed

2 files changed

+7
-19
lines changed

src/components/availability/index.js

Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import React, { useState, useEffect } from "react";
1+
import React, { useState } from "react";
22
import PT from "prop-types";
33

44
import { useSearch } from "../../lib/search";
@@ -24,25 +24,18 @@ export default function Availability({
2424
const handleAvailableClicked = () => {
2525
const newValue = !isAvailableSelected;
2626
setIsAvailableSelected(newValue);
27+
search[selector]({
28+
isAvailableSelected: newValue,
29+
});
2730
};
2831

2932
const handleUnvailableClicked = () => {
3033
const newValue = !isUnavailableSelected;
3134
setIsUnavailableSelected(newValue);
32-
};
33-
34-
useEffect(() => {
3535
search[selector]({
36-
isAvailableSelected: isAvailableSelected,
37-
isUnavailableSelected: isUnavailableSelected,
36+
isUnavailableSelected: newValue,
3837
});
39-
}, [selector, isAvailableSelected, isUnavailableSelected]);
40-
41-
/* This triggers the child to render when props is changed */
42-
useEffect(() => {
43-
setIsAvailableSelected(availableSelected);
44-
setIsUnavailableSelected(unavailableSelected);
45-
}, [availableSelected, unavailableSelected]);
38+
};
4639

4740
return (
4841
<div className={styles.availabilityContainer}>

src/components/tagList/index.js

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,18 +24,13 @@ export default function TagList({ tags, selected, selector }) {
2424

2525
setSelectedTags(selection);
2626
setUpdated(updated + 1);
27+
search[selector](selection);
2728
};
2829

2930
const handleShowMores = () => {
3031
setShowAll(true);
3132
};
3233

33-
useEffect(() => {
34-
if (selector) {
35-
search[selector](selectedTags);
36-
}
37-
}, [updated]);
38-
3934
/* This triggers the child to render when props.selected is changed */
4035
useEffect(() => {
4136
setSelectedTags(selected);

0 commit comments

Comments
 (0)