Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

[$200] Clean up challenge issues #424

Closed
jmgasper opened this issue Aug 12, 2021 · 6 comments
Closed

[$200] Clean up challenge issues #424

jmgasper opened this issue Aug 12, 2021 · 6 comments

Comments

@jmgasper
Copy link
Collaborator

@afrisalyp - Can we address these issues please?

Issue 1

topcoder-x-ui/src/services/ProjectService.js, createHook function, not implemented correctly.

The registeredWebhookId should be specific to each repo, not to project. Since the project has multiple repos, there are also multiple registeredWebhookIds for each project

Issue 2

topcoder-x-ui/src/services/IssueService.js, create function, it always uses first repo url to create issue, this is not correct. Since multiple repo urls exist, it should allow user to choose a repo to create issue.

The UI src/front/src/app/upsertissue should also be updated to allow user to select repo url

We can remove the unused code

Issue 3

topcoder-x-ui/src/services/IssueService.js, recreate function, it always uses first repo url to create issue, this is not correct. Since multiple repo urls exist, it should use given issue.url to determine the repo to use.

Issue 4

topcoder-x-ui/src/services/UserService.js, search function, pagination not implemented correctly. Assume there are 20 records in GithubUserMapping table, 30 records in GitlabUserMapping table, then UI shows only 1 page with 20 records, this is certainly wrong

Issue 5

topcoder-x-ui/src/services/ProjectService.js, transferOwnerShip / topcoder-x-ui/src/services/ProjectService.js, _validateProjectData function, should validate all repo urls, not just the first one

Issue 6

User mapping page, search with a non-existing name like "xxxxxx", then use delete keyboard to delete the name, the search box disappear.

See https://youtu.be/EZ8PC2jHio8

Issue 7

topcoder-x-ui/src/common/db-helper.js, queryOneActiveProject and queryOneActiveProjectWithFilter topcoder-x-processor/utils/db-helper.js, queryOneActiveProject

Previously they use repoUrl (which has index) to query, now scan is used. This causes performance decrease.

Ideally you can create another table like "Repository" to store repo urls, it has many-to-one relationship to "Project" table. So that given a repo url, query "Repository" table first then query "Project" table. By this way scan is avoided

Issue 8

topcoder-x-ui/src/services/UserService.js, search function, line 182 and line 183, you scan whole tables of GithubUserMapping and GitlabUserMapping without any filter. Should apply the filter when scan

@jmgasper
Copy link
Collaborator Author

Challenge https://www.topcoder.com/challenges/b3718d33-0d3b-4b27-a431-756e9d3880eb has been created for this ticket.

This is an automated message for ghostar2020 via Topcoder X

@jmgasper
Copy link
Collaborator Author

Challenge https://www.topcoder.com/challenges/b3718d33-0d3b-4b27-a431-756e9d3880eb has been assigned to afrisalyp.

This is an automated message for ghostar2020 via Topcoder X

@jmgasper
Copy link
Collaborator Author

Challenge https://www.topcoder.com/challenges/b3718d33-0d3b-4b27-a431-756e9d3880eb afrisalyp has been unassigned.

This is an automated message for ghostar2020 via Topcoder X

@jmgasper
Copy link
Collaborator Author

Challenge https://www.topcoder.com/challenges/b3718d33-0d3b-4b27-a431-756e9d3880eb has been assigned to afrisalyp.

This is an automated message for ghostar2020 via Topcoder X

@afrisalyp
Copy link
Collaborator

@jmgasper

Please execute npm run create-tables and npm run migrate-repo-url first if we deploy in existing environtment.
Thanks.

@jmgasper
Copy link
Collaborator Author

Payment task has been updated: https://www.topcoder.com/challenges/b3718d33-0d3b-4b27-a431-756e9d3880eb
Payments Complete
Winner: afrisalyp
Copilot: ghostar2020
Challenge b3718d33-0d3b-4b27-a431-756e9d3880eb has been paid and closed.

This is an automated message for ghostar2020 via Topcoder X

@jmgasper jmgasper added this to the Version 1.2 milestone Sep 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants