Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

[$75] Create pull requests for recent changes, and fix review issue #351

Closed
jmgasper opened this issue Nov 3, 2020 · 4 comments
Closed

Comments

@jmgasper
Copy link
Collaborator

jmgasper commented Nov 3, 2020

@anonymousjaggu - Can you do the follow please?

  1. Fix the review issue here:

For ticket #346

As per the attached spec in the ticket, iframe url must be configurable but in the submission, it is hardcoded.

Here's an excerpt in file topcoder-x-ui/src/front/src/components/common/footer.html:

<script>
  function prepareFrame() {
    var ifrm = document.createElement("iframe");
    ifrm.setAttribute("src", "https://accounts-auth0.topcoder-dev.com/");
    ifrm.style.width = "0px";
    ifrm.style.height = "0px";
    document.body.appendChild(ifrm);
  }
  window.onload = prepareFrame;
</script>
  1. Create pull requests for the UI and processor with the changes from the challenge please?
@jmgasper
Copy link
Collaborator Author

jmgasper commented Nov 3, 2020

Contest https://www.topcoder.com/challenges/30148396 has been created for this ticket.

This is an automated message for ghostar via Topcoder X

@jmgasper
Copy link
Collaborator Author

jmgasper commented Nov 3, 2020

Contest https://www.topcoder.com/challenges/30148396 has been updated - it has been assigned to anonymousjaggu.

This is an automated message for ghostar via Topcoder X

@anonymousjaggu
Copy link
Collaborator

@jmgasper FYI I am re-using the existing code for adding the refresh UI as below
image
so the URL will be coming from the config

@jmgasper
Copy link
Collaborator Author

jmgasper commented Nov 4, 2020

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30148396

This is an automated message for ghostar via Topcoder X

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants