Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

[$75] Test invitation acceptance on Github #294

Closed
jmgasper opened this issue Mar 20, 2020 · 8 comments
Closed

[$75] Test invitation acceptance on Github #294

jmgasper opened this issue Mar 20, 2020 · 8 comments

Comments

@jmgasper
Copy link
Collaborator

@afrisalyp - We're concerned that the fixes here may not be working properly:

#111

Can you have a look and let me know please?

If you need help with setup to be able to test, let me know what you need and I'll work with Topcoder to get it for you.

@jmgasper
Copy link
Collaborator Author

Contest https://www.topcoder.com/challenges/30120315 has been created for this ticket.

This is an automated message for ghostar via Topcoder X

@jmgasper
Copy link
Collaborator Author

Contest https://www.topcoder.com/challenges/30120315 has been updated - it has been assigned to afrisalyp.

This is an automated message for ghostar via Topcoder X

@afrisalyp
Copy link
Collaborator

@jmgasper

I've investigated and reproduced the steps to invite user to a Github team.
I found that it won't automatically add users to the team, but the browser will be redirected to an invitation confirmation page.

You can see the screencast.
https://drive.google.com/open?id=1_bpWz0SpBtE_ZkeuQex5TxqNhGMlCn7m

Do you think that the behavior is not proper and do we need to fix it so it will automatically accept the invitation?

@jmgasper
Copy link
Collaborator Author

@afrisalyp - Can we automatically accept the invitation? I'll log a new ticket for that, but want to make sure that's something we can do.

@afrisalyp
Copy link
Collaborator

afrisalyp commented Mar 22, 2020

@jmgasper

Update:

The invitation page is an invitation to the team's organization, not the team. Once we accept the invitation, we are joined the organization and we will automatically join the team.

If we are already joined the organization and we want to join another team that is in the organization, we won't be redirected to the invitation page anymore, and it will automatically accept the team invitation.

https://drive.google.com/open?id=1Uph02hrAK8NoMUedfz74qqCtbA9_18iC

But I see that after the process is succeeded, it doesn't properly redirect to the "Add user success" page.

I don't see that the invitation page to the organization can be automatically accepted.

@jmgasper
Copy link
Collaborator Author

@afrisalyp - Ok, sorry for the delay here.

So we need to:

  1. Set expectations that we can't automatically accept an invitation
  2. Fix the issue where the success page isn't being shown

Is that correct?

@afrisalyp
Copy link
Collaborator

@jmgasper - Yes, that's correct.

@jmgasper
Copy link
Collaborator Author

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30120315

This is an automated message for ghostar via Topcoder X

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants