[$60] Gitlab token expiration

[jmgasper]

@afrisalyp - I have a report from a TC admin that their Gitlab token expires on a regular basis (every time he logs in). I haven't seen this myself - mine's been fine for at least a couple weeks now.

Is there anything you can think of that might cause this discrepancy? Do you know what the normal expiration time should be?

[jmgasper]

Contest https://www.topcoder.com/challenges/30108782 has been created for this ticket.

This is an automated message for ghostar via Topcoder X

[jmgasper]

Contest https://www.topcoder.com/challenges/30108782 has been updated - it has been assigned to afrisalyp.

This is an automated message for ghostar via Topcoder X

[afrisalyp]

@jmgasper
Github doesn't have token expiration, which means the token never expires.

But Gitlab has token expiration. By default, if we request to https://gitlab.com/oauth/token we will get results with expires_in. But sometimes for some gitlab accounts, we don't get the param. Not really sure what's the cause.

Currently, if we don't have the expires_in, we set the expires_in in only 3600 seconds.

What do you think that we should handle this?

[jmgasper]

How far out can we set the expires_in value? A couple weeks instead of an hour would make sense.

[afrisalyp]

Yeah, I think two weeks is proper.
Is it acceptable?

[jmgasper]

Yep, is that an easy change?

[afrisalyp]

Yes. We can change this code
https://github.com/topcoder-platform/topcoder-x-ui/blob/develop/src/common/constants.js#L46

I can raise a PR if it's needed.

[jmgasper]

Payment task has been updated: https://software.topcoder-dev.com/review/actions/ViewProjectDetails?pid=30108782

This is an automated message for ghostar via Topcoder X