Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

[$80] Processing order #24

Closed
jmgasper opened this issue Jun 30, 2018 · 4 comments
Closed

[$80] Processing order #24

jmgasper opened this issue Jun 30, 2018 · 4 comments
Assignees

Comments

@jmgasper
Copy link
Collaborator

jmgasper commented Jun 30, 2018

If a user creates a ticket with an assignee, it seems like now we handle two separate events - one for the created event and one for assigning the user.

This caused a problem in my testing because the assignee event was processed first, before there was a challenge to assign to, and then the assignee was processed twice.

If we can handle this case and do the creation with the assignee as part of the challenge creation request, that would be preferable.

screen shot 2018-06-30 at 1 46 18 pm

@jmgasper jmgasper changed the title [$30] Processing order [$40] Processing order Jun 30, 2018
@veshu
Copy link
Contributor

veshu commented Jul 2, 2018

@jmgasper I think its not possible. as github send separate webhook for assignement.
Now we have handling assignment during create as well. but I don't see a way to find if current issue is being creating challenge or not before trying to assingn.

One thing we can do is remove the challenge assignment during issue create and only handle during assignement event, and we could push assignement event on retry event for this case(challenge not found without showing error here and showing comment only after retry count has exceded).

Can you please bring some suggestion here how it can be implemented?

@jmgasper
Copy link
Collaborator Author

jmgasper commented Jul 5, 2018

Ok - let's remove the challenge assignment during issue create. That will better match the Github flow - we just have to make sure it also works for Gitlab.

@jmgasper jmgasper self-assigned this Jul 5, 2018
@jmgasper jmgasper changed the title [$40] Processing order [$80] Processing order Jul 5, 2018
@jmgasper
Copy link
Collaborator Author

jmgasper commented Jul 5, 2018

Bumped the payment for the extra work.

@veshu
Copy link
Contributor

veshu commented Jul 6, 2018

@jmgasper fixed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants