Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

[$100] Clean up review issues #132

Closed
jmgasper opened this issue Jan 23, 2019 · 4 comments
Closed

[$100] Clean up review issues #132

jmgasper opened this issue Jan 23, 2019 · 4 comments

Comments

@jmgasper
Copy link
Collaborator

These review issues from the January release challenge need to be fixed:

Issue 1

Add Github / Gitlab group URL to confirmation screen on Git access link #115

GitHub - buggy

  • Please see n115_01_github.png - n115_04_github.png
  • Notice that there are 2 teams (n115_01_github.png) but the URL is the same for both teams (n115_02_github.png and n115_03_github.png).
  • Also the URL https://github.com/orgs/tcx/teams/test is not valid. It leads to a 404 page (n115_04_github.png).

Issue 2

Owner is used every where even if copilot is set
http://prntscr.com/m7u0zo
#118

This brings lots of unnecessary changes from copilot to owner.
if you just check project has copilot or not if not then return owner in getRepositoryCopilot method would be sufficient.

@jmgasper
Copy link
Collaborator Author

Contest https://www.topcoder.com/challenges/30080161 has been created for this ticket.

This is an automated message for ghostar via Topcoder X

@jmgasper
Copy link
Collaborator Author

Contest https://www.topcoder.com/challenges/30080161 has been updated - it has been assigned to nauhil.

This is an automated message for ghostar via Topcoder X

@jmgasper
Copy link
Collaborator Author

Contest https://www.topcoder.com/challenges/30080161 has been updated - it has been assigned to nauhil.

This is an automated message for ghostar via Topcoder X

@jmgasper
Copy link
Collaborator Author

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30080161

This is an automated message for ghostar via Topcoder X

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants