Merge branch 'develop' of https://github.com/topcoder-platform/topcoder-x-processor into issue-232

Author: afrisalyp

package.json

@@ -29,7 +29,7 @@
     "axios": "^0.19.0",
     "circular-json": "^0.5.7",
     "config": "^1.30.0",
-    "dynamoose": "^1.1.0",
+    "dynamoose": "^1.11.1",
     "fs-extra": "^7.0.0",
     "get-parameter-names": "^0.3.0",
     "github": "^12.1.0",

services/IssueService.js

@@ -73,7 +73,9 @@ async function ensureChallengeExists(event, issue, create = true) {
     provider: issue.provider,
     repositoryId: issue.repositoryId
   });
-
+  logger.debug(`DB Issue number: ${issue.number}`);
+  logger.debug(`DB Issue provider: ${issue.provider}`);
+  logger.debug(`DB Issue repository: ${issue.repositoryId}`);
   if (dbIssue && dbIssue.status === 'challenge_creation_pending') {
     logger.debug('dbIssue is PENDING');
     throw errors.internalDependencyError(`Challenge for the updated issue ${issue.number} is creating, rescheduling this event`);

utils/db-helper.js

@@ -18,9 +18,9 @@ const logger = require('./logger');
  */
 async function getById(model, id) {
   return await new Promise((resolve, reject) => {
-    model.query('id').eq(id).exec((err, result) => {
+    model.query('id').eq(id).consistent().exec((err, result) => {
       if (err) {
-        reject(err);
+        return reject(err);
       }
 
       return resolve(result[0]);
@@ -36,9 +36,9 @@ async function getById(model, id) {
  */
 async function scan(model, scanParams) {
   return await new Promise((resolve, reject) => {
-    model.scan(scanParams).exec((err, result) => {
+    model.scan(scanParams).consistent().exec((err, result) => {
       if (err) {
-        reject(err);
+        return reject(err);
       }
 
       return resolve(result.count === 0 ? [] : result);
@@ -56,12 +56,12 @@ async function scanOne(model, scanParams) {
   logger.debug('Enter scanOne.');
 
   return await new Promise((resolve, reject) => {
-    model.scan(scanParams).exec((err, result) => {
+    model.scan(scanParams).consistent().exec((err, result) => {
       if (err) {
         logger.debug(`scanOne. Error. ${err}`);
-        reject(err);
+        return reject(err);
       }
-      logger.debug(`scanOne. Result.`);
+      logger.debug('scanOne. Result.');
       logger.debug(result);
 
       return resolve(result.count === 0 ? null : result[0]);
@@ -78,7 +78,7 @@ async function updateMany(model, collection) {
   await new Promise((resolve, reject) => {
     model.batchPut(collection, (err, result) => {
       if (err) {
-        reject(err);
+        return reject(err);
       }
 
       resolve(result);
@@ -97,7 +97,7 @@ async function create(Model, data) {
     const dbItem = new Model(data);
     dbItem.save((err) => {
       if (err) {
-        reject(err);
+        return reject(err);
       }
 
       return resolve(dbItem);
@@ -120,7 +120,7 @@ async function update(Model, id, data) {
   return await new Promise((resolve, reject) => {
     dbItem.save((err) => {
       if (err) {
-        reject(err);
+        return reject(err);
       }
 
       return resolve(dbItem);
@@ -139,7 +139,7 @@ async function remove(Model, queryParams) {
     if (dbItem != null) {
       dbItem.delete((err) => {
         if (err) {
-          reject(err);
+          return reject(err);
         }
 
         resolve(dbItem);

utils/topcoder-api-helper.js

@@ -37,12 +37,13 @@ if (config.TC_DEV_ENV) {
   topcoderApiProjects = topcoderDevApiProjects;
   topcoderApiChallenges = topcoderDevApiChallenges;
 }
-//Timeout increase to 5 minutes
-topcoderApiChallenges.ApiClient.timeout=300000;
-
 // Init the API instances
 const projectsClient = topcoderApiProjects.ApiClient.instance;
 const challengesClient = topcoderApiChallenges.ApiClient.instance;
+
+//Timeout increase to 5 minutes
+challengesClient.timeout=300000;
+
 const bearer = projectsClient.authentications.bearer;
 bearer.apiKeyPrefix = 'Bearer';
 challengesClient.authentications.bearer = bearer;
@@ -157,6 +158,12 @@ async function updateChallenge(id, challenge) {
     const statusCode = response.result ? response.result.status : null;
     loggerFile.info(`EndPoint: PUT /challenges/${id},  PUT parameters: null, Status Code:${statusCode}, Response: ${circularJSON.stringify(response)}`);
   } catch (err) {
+    logger.error('updateChallenge ERROR.');
+    logger.error(`EndPoint: PUT /challenges/${id}`);
+    logger.error(`${err.message}`);
+    logger.error(`Request: ${JSON.stringify(err.config)}`);
+    logger.error(`Response Data: ${err.response.data}`);
+
     loggerFile.info(`EndPoint: PUT /challenges/${id},  PUT parameters: null, Status Code:null,
     Error: 'Failed to update challenge.', Details: ${circularJSON.stringify(err)}`);
     throw errors.convertTopcoderApiError(err, 'Failed to update challenge.');
@@ -187,6 +194,12 @@ async function activateChallenge(id) {
     POST parameters: null, Status Code:${statusCode}, Response: ${circularJSON.stringify(response)}`);
     logger.debug(`Challenge ${id} is activated successfully.`);
   } catch (err) {
+    logger.error('activateChallenge ERROR.');
+    logger.error(`EndPoint: POST /challenges/${id}/activate`);
+    logger.error(`${err.message}`);
+    logger.error(`Request: ${JSON.stringify(err.config)}`);
+    logger.error(`Response Data: ${err.response.data}`);
+
     loggerFile.info(`EndPoint: POST /challenges/${id}/activate,  POST parameters: null, Status Code:null,
     Error: 'Failed to activate challenge.', Details: ${circularJSON.stringify(err)}`);
     throw errors.convertTopcoderApiError(err, 'Failed to activate challenge.');
@@ -216,6 +229,13 @@ async function getChallengeById(id) {
     loggerFile.info(`EndPoint: GET challenges/${id},  GET parameters: null, Status Code:${statusCode}, Response: ${circularJSON.stringify(response)}`);
     return challenge;
   } catch (err) {
+    logger.error('getChallengeById ERROR.');
+    logger.error(`EndPoint: GET challenges/${id}`);
+    logger.error(`${err.message}`);
+    logger.error(`Request: ${JSON.stringify(err.config)}`);
+    logger.error(`Response Data: ${err.response.data}`);
+
+    logger.error(JSON.stringify(err));
     throw errors.convertTopcoderApiError(err, 'Failed to get challenge details by Id');
   }
 }
@@ -239,6 +259,11 @@ async function closeChallenge(id, winnerId) {
     loggerFile.info(`EndPoint: POST /challenges/${id}/close,  POST parameters: null, Status Code:${statusCode}, Response:${circularJSON.stringify(response)}`);
     logger.debug(`Challenge ${id} is closed successfully.`);
   } catch (err) {
+    logger.error('Closing challenge ERROR.');
+    logger.error(`EndPoint: POST /challenges/${id}/close`);
+    logger.error(`${err.message}`);
+    logger.error(`Request: ${JSON.stringify(err.config)}`);
+    logger.error(`Response Data: ${err.response.data}`);
     loggerFile.info(`EndPoint: POST /challenges/${id}/close, POST parameters: null, Status Code:null,
     Error: 'Failed to close challenge.', Details: ${circularJSON.stringify(err)}`);
     throw errors.convertTopcoderApiError(err, 'Failed to close challenge.');