Merge pull request #96 from 52cs/fix-empty-tags/Issue#453

fix-empty-tags

Author: jmgasper

services/ChallengeService.js

@@ -49,7 +49,7 @@ async function process(event) {
 }
 
 process.schema = Joi.object().keys({
-  event: Joi.string().valid('challengeUUIDTags.update').required(),
+  event: Joi.string().valid('challengeTags.update').required(),
   data: Joi.object().keys({
     challengeUUIDsList: Joi.array().items(
       Joi.alternatives().try(Joi.string(), Joi.array().items(Joi.string()))

services/CopilotPaymentService.js

@@ -194,7 +194,7 @@ async function handlePaymentAdd(event, payment) {
       const newChallenge = {
         name: challengeTitle,
         projectId: project.tcDirectId,
-        tags: project.tags.split(','),
+        tags: !!project.tags ? project.tags.split(',') : [],
         detailedRequirements: challengeRequirements,
         prizes: [payment.amount],
         reviewType: 'INTERNAL'

services/IssueService.js

@@ -636,7 +636,7 @@ async function handleIssueCreate(event, issue, forceAssign = false) {
     issue.challengeUUID = await topcoderApiHelper.createChallenge({
       name: issue.title,
       projectId,
-      tags: project.tags.split(','),
+      tags: !!project.tags ? project.tags.split(',') : [],
       detailedRequirements: issue.body,
       prizes: issue.prizes
     });

utils/kafka-consumer.js

@@ -48,7 +48,7 @@ function messageHandler(messageSet) {
       .process(event)
       .catch(logger.error);
     }
-    if (event && _.includes(['challengeUUIDTags.update']
+    if (event && _.includes(['challengeTags.update']
       , event.event)) {
       ChallengeService
       .process(event)

utils/topcoder-api-helper.js

@@ -75,6 +75,7 @@ async function createChallenge(challenge) {
     }],
     timelineTemplateId: config.DEFAULT_TIMELINE_TEMPLATE_ID,
     projectId: challenge.projectId,
+    tags: challenge.tags,
     trackId: config.DEFAULT_TRACK_ID,
     legacy: {
       pureV5Task: true