Review fixes

Author: sharathkumaranbu

src/common/helper.js

@@ -26,7 +26,9 @@ const schemaForRC = Joi.object({
 function readFromRCFile (filename, cliParams) {
   logger.info('Reading from topcoder rc file...')
   const rcObject = JSON.parse(fs.readFileSync(filename).toString())
-  cliParams.challengeIds = cliParams.challengeIds.split(',')
+  if (cliParams.challengeIds) {
+    cliParams.challengeIds = cliParams.challengeIds.split(',')
+  }
   // Override values from RC file with CLI params
   return validateRCObject(_.merge(rcObject, _.pick(cliParams, ['username', 'password', 'challengeIds'])))
 }

src/services/uploadSubmissionService.js

@@ -16,9 +16,6 @@ const logger = require('../common/logger')
  */
 async function smart (currDir, cliParams) {
   const { username, password, challengeIds } = helper.readFromRCFile(path.join(currDir, constants.rc.name), cliParams)
-  console.log(username)
-  console.log(password)
-  console.log(challengeIds)
   const userId = await helper.getUserId(username)
   const submissionName = helper.submissionNameFromUserId(userId)
   const submissionData = helper.archiveCodebase(currDir)