Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

Remove button is still present even after the Email account is removed. #561

Open
sandhiyakavi opened this issue Nov 1, 2021 · 16 comments

Comments

@sandhiyakavi
Copy link
Collaborator

Description:
Remove button is still present even after the Email account is removed.

bandicam.2021-11-01.17-05-05-002.mp4

image

@maxceem maxceem changed the title Remove button is still present even after the Email account is removed. [$20] Remove button is still present even after the Email account is removed. Nov 2, 2021
@maxceem maxceem added the CF label Nov 2, 2021
@maxceem
Copy link
Contributor

maxceem commented Nov 2, 2021

@mahidulalvi-bonic would you like to handle this issue?

@ghost
Copy link

ghost commented Nov 2, 2021

@maxceem, yes, when do you need it?

@maxceem
Copy link
Contributor

maxceem commented Nov 2, 2021

@mahidulalvi-bonic preferable within 24 hours. But 48 would be also fine for this one.

@ghost
Copy link

ghost commented Nov 2, 2021

Okay, should be done in 24. Thanks.

@maxceem maxceem assigned ghost Nov 2, 2021
@ghost
Copy link

ghost commented Nov 4, 2021

Hi @maxceem, I couldn't reproduce the issue using a Gmail & an Exchange account. From the video, it seems the screen still works like it used to before I worked on the delete functionality. And I also saw new changes in the dev branch, is it possible this is a regression?

I tried with dev branch of taas-app & taas-apis.

@maxceem
Copy link
Contributor

maxceem commented Nov 4, 2021

hi @mahidulalvi-bonic I'm not sure if this is regression issue or existent issue which started showing up.

Did you try this on DEV https://platform.topcoder-dev.com/taas/myteams/16786/positions/e7c0d8c0-3e88-46ab-babf-55699bc7a8e6/candidates/interviews without running it locally?

I can see some warning in browser console which might be related:
react-dom.development.js:82 Warning: Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in a useEffect cleanup function. in Ju (created by Xd)

@ghost
Copy link

ghost commented Nov 4, 2021

@maxceem, I just tried in dev with an Exchange account in the URL you gave above. Couldn't reproduce the issue.

@ghost
Copy link

ghost commented Nov 4, 2021

I did try in incognito, could it be that you have an older version of the app installed?

@maxceem
Copy link
Contributor

maxceem commented Nov 4, 2021

could it be that you have an older version of the app installed?

Not sure which app you mean, when we use link https://platform.topcoder-dev.com/taas/myteams/16786/positions/e7c0d8c0-3e88-46ab-babf-55699bc7a8e6/candidates/interviews we (I mean you and me) use the same version of TaaS App. Strange that it happens to me, but not to you.

If you cannot reproduce this issue, I guess you might leave it as I don't have other ideas why it is reproducible for me, but not for you.

@ghost
Copy link

ghost commented Nov 4, 2021

Here is a recording how I saw

Screencast.2021-11-04.05.06.29.mp4

@ghost
Copy link

ghost commented Nov 4, 2021

It could be a cached version of the web app.. Maybe try deleting all app data & cache from application tab in dev tools?

@maxceem
Copy link
Contributor

maxceem commented Nov 4, 2021

It seems that for me it also doesn't happen every time. I tried it one more time and it worked good this time (even without cleaning cache), though I could still see warning in the browser console:

Warning: Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in a useEffect cleanup function.
    in Ju (created by Xd)

@ghost
Copy link

ghost commented Nov 4, 2021

@maxceem, it would be great if you could make a short video of it, with the console and network tabs shown in dev tools. I still couldn't reproduce it.

@maxceem
Copy link
Contributor

maxceem commented Nov 5, 2021

@mahidulalvi-bonic unassigning you for now as I also cannot reproduce it now.

@sdgun could you please try one more time? It seems that this issue has been fixed by fixing some other issue.

@maxceem maxceem unassigned ghost Nov 5, 2021
@maxceem maxceem changed the title [$20] Remove button is still present even after the Email account is removed. Remove button is still present even after the Email account is removed. Nov 5, 2021
@sdgun
Copy link

sdgun commented Nov 5, 2021

@maxceem Tried with few users, this is not reproduced.

@maxceem
Copy link
Contributor

maxceem commented Nov 5, 2021

Ok marking it as passing QA for now, but feel free to fail it again if you see this issue happen again.

@maxceem maxceem self-assigned this Nov 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants