Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

No validation when deleting the values in resources and duration fields in Team Details page #321

Closed
sdgun opened this issue Jun 16, 2021 · 9 comments

Comments

@sdgun
Copy link

sdgun commented Jun 16, 2021

Steps
Go to https://platform.topcoder-dev.com/taas/myteams/createnewteam
Click select button in the 'SELECT A ROLE' box (or use any flow)
Select a role
Click Search
Click Submit
Click Continue
Enter a team name
Delete the values in resources and duration fields

Current behavior
No validation message, submit button is enabled. But the API throws an error and the project is not submitted

Expected behavior
Should show a validation message

image

image

@sdgun
Copy link
Author

sdgun commented Jun 21, 2021

Verified in Dev, this issue is still not fixed. The validation message of the fields gets removed when removing data from another field

2021-06-21_14-50-25.mp4

@sexta13
Copy link

sexta13 commented Jun 24, 2021

To fix this, can we disable the input of numbers with the keyboard? just increment and decrement in the buttons?

@nikolay83
Copy link
Collaborator

What is the effort of fixing it this way vs the effort of keeping the input of numbers with the keyboard?

@sexta13
Copy link

sexta13 commented Jun 25, 2021

the first approach I already implemented, the one with the keyboard I would have to understand better the react-final-form...which is somehow hard to understand. But maybe other contestants have different opinion.

@sexta13
Copy link

sexta13 commented Jun 25, 2021

https://monosnap.com/file/e0pFxGC2dStL8RnBHr0yEv8jsr94gA

This is how it looks. This way the user is unable to put invalid values. If we have + an - buttons, why to enable the input directly?

@sdgun
Copy link
Author

sdgun commented Jun 30, 2021

Verified in Dev, validation error msg is displayed when deleting the values.

image

@sdgun
Copy link
Author

sdgun commented Jul 5, 2021

@nikolay83 This issue can be seen again in Dev.

image

@sdgun
Copy link
Author

sdgun commented Jul 6, 2021

Verified in Dev, issue is fixed.

image

@sdgun sdgun added this to the 7th July Release milestone Jul 7, 2021
@sdgun
Copy link
Author

sdgun commented Jul 7, 2021

Verified in production

image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants