Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

Commit c8ce24b

Browse files
committed
fix: show job description for resources
ref issue #24
1 parent 9c2d2b5 commit c8ce24b

File tree

1 file changed

+18
-9
lines changed
  • src/routes/MyTeamsDetails/components/TeamMembers

1 file changed

+18
-9
lines changed

src/routes/MyTeamsDetails/components/TeamMembers/index.jsx

Lines changed: 18 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ import Input from "components/Input";
2121
import { skillShape } from "components/SkillsList";
2222

2323
const TeamMembers = ({ team }) => {
24-
const { resources } = team;
24+
const { resources, jobs } = team;
2525
const [filter, setFilter] = useState("");
2626

2727
const filteredMembers = useMemo(
@@ -44,6 +44,13 @@ const TeamMembers = ({ team }) => {
4444
[resources, filter]
4545
);
4646

47+
const filteredMembersWithJobs = useMemo(() => {
48+
return filteredMembers.map((member) => ({
49+
...member,
50+
job: _.find(jobs, { id: member.jobId }) || {},
51+
}));
52+
}, [filteredMembers, jobs]);
53+
4754
const onFilterChange = useCallback(
4855
(event) => {
4956
setFilter(event.target.value);
@@ -65,8 +72,8 @@ const TeamMembers = ({ team }) => {
6572
const pagesTotal = Math.ceil(filteredMembers.length / perPage);
6673

6774
const pageMembers = useMemo(
68-
() => filteredMembers.slice((page - 1) * perPage, page * perPage),
69-
[filteredMembers, page, perPage]
75+
() => filteredMembersWithJobs.slice((page - 1) * perPage, page * perPage),
76+
[filteredMembersWithJobs, page, perPage]
7077
);
7178

7279
const onPageClick = useCallback(
@@ -90,10 +97,10 @@ const TeamMembers = ({ team }) => {
9097
}
9198
/>
9299
{resources.length === 0 && <div styleName="no-members">No members</div>}
93-
{resources.length > 0 && filteredMembers.length === 0 && (
100+
{resources.length > 0 && filteredMembersWithJobs.length === 0 && (
94101
<div styleName="no-members">No members matching filter</div>
95102
)}
96-
{filteredMembers.length > 0 && (
103+
{filteredMembersWithJobs.length > 0 && (
97104
<div styleName="table">
98105
{pageMembers.map((member) => (
99106
<div styleName="table-row" key={member.id}>
@@ -107,7 +114,9 @@ const TeamMembers = ({ team }) => {
107114
/>
108115
</div>
109116
<div styleName="table-group-first-inner">
110-
<div styleName="table-cell cell-role">{member.role}</div>
117+
<div styleName="table-cell cell-role">
118+
{member.job.description}
119+
</div>
111120
<div styleName="table-cell cell-date">
112121
{moment(member.startDate).format(DAY_FORMAT)} -{" "}
113122
{moment(member.endDate).format(DAY_FORMAT)}
@@ -157,15 +166,15 @@ const TeamMembers = ({ team }) => {
157166
type="secondary"
158167
onClick={showMore}
159168
disabled={
160-
filteredMembers.length === 0 || // if no members to show
169+
filteredMembersWithJobs.length === 0 || // if no members to show
161170
page === pagesTotal // if we are already on the last page
162171
}
163172
>
164173
Show More
165174
</Button>
166-
{filteredMembers.length > 0 && (
175+
{filteredMembersWithJobs.length > 0 && (
167176
<Pagination
168-
total={filteredMembers.length}
177+
total={filteredMembersWithJobs.length}
169178
currentPage={page}
170179
perPage={perPage}
171180
onPageClick={onPageClick}

0 commit comments

Comments
 (0)