Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

Commit bd62f71

Browse files
committed
fix(create-new-team): display spinner while searching inside progress card button
* Fix an issue which was preventing loading spinner to be displayed inside the submit button of progress card. * Adjust progress card percentage values, as per the design. Addresses #406 (comment)
1 parent dde1282 commit bd62f71

File tree

3 files changed

+8
-9
lines changed

3 files changed

+8
-9
lines changed

src/routes/CreateNewTeam/components/SearchContainer/index.jsx

+6-7
Original file line numberDiff line numberDiff line change
@@ -80,11 +80,10 @@ function SearchContainer({
8080
return <NoMatchingProfilesResultCard role={matchingRole} />;
8181
};
8282

83-
const getPercentage = useCallback(() => {
84-
if (searchState === "searching") return "26";
85-
if (matchingRole) return "53";
86-
return "84";
87-
}, [searchState, matchingRole]);
83+
const progressBarPercentage = useMemo(
84+
() => (searchState === "searching" ? 53 : 84),
85+
[searchState]
86+
);
8887

8988
return (
9089
<div styleName="page">
@@ -94,14 +93,14 @@ function SearchContainer({
9493
<Progress
9594
isDisabled={
9695
!buttonClickable ||
97-
searchState === "searching" ||
9896
(searchState === "done" && (!addedRoles || !addedRoles.length))
9997
}
98+
isSearching={searchState === "searching"}
10099
onClick={() => setAddAnotherOpen(true)}
101100
extraStyleName={progressStyle}
102101
buttonLabel="Continue"
103102
stages={stages}
104-
percentage={getPercentage()}
103+
percentage={progressBarPercentage}
105104
/>
106105
</div>
107106
<AddAnotherModal

src/routes/CreateNewTeam/components/SubmitContainer/index.jsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ function SubmitContainer({
163163
isDisabled={!buttonClickable}
164164
buttonLabel="Continue"
165165
stages={stages}
166-
percentage="98"
166+
percentage="84"
167167
/>
168168
</div>
169169
<AddAnotherModal

src/routes/CreateNewTeam/pages/CreateTaasPayment/index.jsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ const CreateTassPayment = () => {
160160
stages={stages}
161161
extraStyleName="role-selection final-step"
162162
disabled="true"
163-
percentage="98"
163+
percentage="97"
164164
/>
165165
</div>
166166
);

0 commit comments

Comments
 (0)