refactor: put all actions in one config

we should keep all the actions in one config to avoid name collisions

Author: maxceem

src/components/ReportPopup/actions/index.js

@@ -1,11 +1,7 @@
 /**
  * Report popup actions
  */
-
-export const ACTION_TYPE = {
-  OPEN_REPORT: "OPEN_REPORT",
-  CLOSE_REPORT: "CLOSE_REPORT",
-};
+import { ACTION_TYPE } from "constants";
 
 /**
  * Action to populate the report info and open a report popup

src/components/ReportPopup/reducers/index.js

@@ -2,7 +2,7 @@
  * Reducer for Report popup
  */
 
-import { ACTION_TYPE } from "../actions";
+import { ACTION_TYPE } from "constants";
 
 const initialState = {
   teamName: undefined,

src/constants/index.js

@@ -149,6 +149,9 @@ export const CANDIDATES_SORT_OPTIONS = [
  * All action types
  */
 export const ACTION_TYPE = {
+  /*
+    Position Details
+   */
   LOAD_POSITION: "LOAD_POSITION",
   LOAD_POSITION_PENDING: "LOAD_POSITION_PENDING",
   LOAD_POSITION_SUCCESS: "LOAD_POSITION_SUCCESS",
@@ -160,6 +163,44 @@ export const ACTION_TYPE = {
   UPDATE_CANDIDATE_PENDING: "UPDATE_CANDIDATE_PENDING",
   UPDATE_CANDIDATE_SUCCESS: "UPDATE_CANDIDATE_SUCCESS",
   UPDATE_CANDIDATE_ERROR: "UPDATE_CANDIDATE_ERROR",
+
+  /*
+    withAuthentication
+   */
+  AUTH_USER_SUCCESS: "AUTH_USER_SUCCESS",
+  AUTH_USER_ERROR: "AUTH_USER_ERROR",
+
+  /*
+    Report Popup
+   */
+  OPEN_REPORT: "OPEN_REPORT",
+  CLOSE_REPORT: "CLOSE_REPORT",
+
+  /*
+    Team (project) Members
+  */
+  LOAD_MEMBERS: "LOAD_MEMBERS",
+  LOAD_MEMBERS_PENDING: "LOAD_MEMBERS_PENDING",
+  LOAD_MEMBERS_SUCCESS: "LOAD_MEMBERS_SUCCESS",
+  LOAD_MEMBERS_ERROR: "LOAD_MEMBERS_ERROR",
+  LOAD_INVITES: "LOAD_INVITES",
+  LOAD_INVITES_PENDING: "LOAD_INVITES_PENDING",
+  LOAD_INVITES_SUCCESS: "LOAD_INVITES_SUCCESS",
+  LOAD_INVITES_ERROR: "LOAD_INVITES_ERROR",
+  LOAD_MEMBERS_SUGGESTIONS: "LOAD_MEMBERS_SUGGESTIONS",
+  LOAD_MEMBERS_SUGGESTIONS_PENDING: "LOAD_MEMBERS_SUGGESTIONS_PENDING",
+  LOAD_MEMBERS_SUGGESTIONS_SUCCESS: "LOAD_MEMBERS_SUGGESTIONS_SUCCESS",
+  LOAD_MEMBERS_SUGGESTIONS_ERROR: "LOAD_MEMBERS_SUGGESTIONS_ERROR",
+  REMOVE_MEMBER: "REMOVE_MEMBER",
+  REMOVE_MEMBER_PENDING: "REMOVE_MEMBER_PENDING",
+  REMOVE_MEMBER_SUCCESS: "REMOVE_MEMBER_SUCCESS",
+  REMOVE_MEMBER_ERROR: "REMOVE_MEMBER_ERROR",
+  ADD_MEMBERS: "ADD_MEMBERS",
+  ADD_MEMBERS_PENDING: "ADD_MEMBERS_PENDING",
+  ADD_MEMBERS_SUCCESS: "ADD_MEMBERS_SUCCESS",
+  ADD_MEMBERS_ERROR: "ADD_MEMBERS_ERROR",
+  RESET_MEMBERS_STATE: "RESET_MEMBERS_STATE",
+  CLEAR_MEMBERS_SUGGESTIONS: "CLEAR_MEMBERS_SUGGESTIONS",
 };
 
 /**

src/hoc/withAuthentication/actions/index.js

@@ -1,11 +1,7 @@
 /**
  * Auth User actions
  */
-
-export const ACTION_TYPE = {
-  AUTH_USER_SUCCESS: "AUTH_USER_SUCCESS",
-  AUTH_USER_ERROR: "AUTH_USER_ERROR",
-};
+import { ACTION_TYPE } from "constants";
 
 /**
  * Action to set auth user data
@@ -24,3 +20,11 @@ export const authUserError = (error) => ({
   type: ACTION_TYPE.AUTH_USER_ERROR,
   payload: error,
 });
+
+/**
+ * Action to load project/team members
+ */
+export const loadTeamMembers = (error) => ({
+  type: ACTION_TYPE.AUTH_USER_ERROR,
+  payload: error,
+});

src/hoc/withAuthentication/reducers/index.js

@@ -2,7 +2,7 @@
  * Reducer for `authUser`
  */
 
-import { ACTION_TYPE } from "../actions";
+import { ACTION_TYPE } from "constants";
 
 const initialState = {
   isLoggedIn: null,

src/routes/TeamAccess/actions/index.js

@@ -9,31 +9,7 @@ import {
   getMemberSuggestions,
   postMembers,
 } from "services/teams";
-
-export const ACTION_TYPE = {
-  LOAD_MEMBERS: "LOAD_MEMBERS",
-  LOAD_MEMBERS_PENDING: "LOAD_MEMBERS_PENDING",
-  LOAD_MEMBERS_SUCCESS: "LOAD_MEMBERS_SUCCESS",
-  LOAD_MEMBERS_ERROR: "LOAD_MEMBERS_ERROR",
-  LOAD_INVITES: "LOAD_INVITES",
-  LOAD_INVITES_PENDING: "LOAD_INVITES_PENDING",
-  LOAD_INVITES_SUCCESS: "LOAD_INVITES_SUCCESS",
-  LOAD_INVITES_ERROR: "LOAD_INVITES_ERROR",
-  LOAD_SUGGESTIONS: "LOAD_SUGGESTIONS",
-  LOAD_SUGGESTIONS_PENDING: "LOAD_SUGGESTIONS_PENDING",
-  LOAD_SUGGESTIONS_SUCCESS: "LOAD_SUGGESTIONS_SUCCESS",
-  LOAD_SUGGESTIONS_ERROR: "LOAD_SUGGESTIONS_ERROR",
-  REMOVE_MEMBER: "REMOVE_MEMBER",
-  REMOVE_MEMBER_PENDING: "REMOVE_MEMBER_PENDING",
-  REMOVE_MEMBER_SUCCESS: "REMOVE_MEMBER_SUCCESS",
-  REMOVE_MEMBER_ERROR: "REMOVE_MEMBER_ERROR",
-  ADD_MEMBERS: "ADD_MEMBERS",
-  ADD_MEMBERS_PENDING: "ADD_MEMBERS_PENDING",
-  ADD_MEMBERS_SUCCESS: "ADD_MEMBERS_SUCCESS",
-  ADD_MEMBERS_ERROR: "ADD_MEMBERS_ERROR",
-  CLEAR_ALL: "CLEAR_ALL",
-  CLEAR_SUGGESTIONS: "CLEAR_SUGGESTIONS",
-};
+import { ACTION_TYPE } from "constants"
 
 /**
  * Loads team members
@@ -75,7 +51,7 @@ export const loadInvites = (teamId) => ({
  * Clear team members state
  */
 export const clearAll = () => ({
-  type: ACTION_TYPE.CLEAR_ALL,
+  type: ACTION_TYPE.RESET_MEMBERS_STATE,
 });
 
 /**
@@ -106,7 +82,7 @@ export const removeTeamMember = (teamId, memberId) => ({
  * @returns {Promise<object[]>} list of suggestions or error
  */
 export const loadSuggestions = (fragment) => ({
-  type: ACTION_TYPE.LOAD_SUGGESTIONS,
+  type: ACTION_TYPE.LOAD_MEMBERS_SUGGESTIONS,
   payload: async () => {
     const res = await getMemberSuggestions(fragment);
     return res.data.result.content;
@@ -120,7 +96,7 @@ export const loadSuggestions = (fragment) => ({
  * Clears invite suggestions
  */
 export const clearSuggestions = () => ({
-  type: ACTION_TYPE.CLEAR_SUGGESTIONS,
+  type: ACTION_TYPE.CLEAR_MEMBERS_SUGGESTIONS,
 });
 
 /**

src/routes/TeamAccess/reducers/index.js

@@ -1,7 +1,7 @@
 /**
  * Reducer for Team Access page
  */
-import { ACTION_TYPE } from "../actions";
+import { ACTION_TYPE } from "constants";
 
 const initialState = {
   members: undefined,
@@ -15,7 +15,7 @@ const initialState = {
 
 const reducer = (state = initialState, action) => {
   switch (action.type) {
-    case ACTION_TYPE.CLEAR_ALL:
+    case ACTION_TYPE.RESET_MEMBERS_STATE:
       return initialState;
 
     case ACTION_TYPE.LOAD_MEMBERS_PENDING:
@@ -84,29 +84,29 @@ const reducer = (state = initialState, action) => {
         error: action.payload,
       };
 
-    case ACTION_TYPE.LOAD_SUGGESTIONS_PENDING:
+    case ACTION_TYPE.LOAD_MEMBERS_SUGGESTIONS_PENDING:
       return {
         ...state,
         loading: true,
         error: undefined,
       };
 
-    case ACTION_TYPE.LOAD_SUGGESTIONS_SUCCESS:
+    case ACTION_TYPE.LOAD_MEMBERS_SUGGESTIONS_SUCCESS:
       return {
         ...state,
         suggestions: action.payload,
         loading: false,
         error: undefined,
       };
 
-    case ACTION_TYPE.LOAD_SUGGESTIONS_ERROR:
+    case ACTION_TYPE.LOAD_MEMBERS_SUGGESTIONS_ERROR:
       return {
         ...state,
         loading: false,
         error: action.payload,
       };
 
-    case ACTION_TYPE.CLEAR_SUGGESTIONS:
+    case ACTION_TYPE.CLEAR_MEMBERS_SUGGESTIONS:
       return {
         ...state,
         suggestions: [],