Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

Commit 5ecdfb3

Browse files
committed
fix: review issues
1 parent c3a3c4e commit 5ecdfb3

File tree

3 files changed

+17
-5
lines changed

3 files changed

+17
-5
lines changed

README.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,9 @@ This is a [single-spa](https://single-spa.js.org/) example React microapp.
1818

1919
## Config
2020

21-
For available variables config, please refer to `config/development.js` and `config/production.js`.
21+
For available variables config which depend on the running environment (`development` or `production`), please refer to `config/development.js` and `config/production.js`.
22+
23+
For application constants which don't depend on the running environment use `src/constants/index.js`.
2224

2325
## NPM Commands
2426

src/routes/MyTeamsList/components/TeamCard/index.jsx

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,9 +46,11 @@ const TeamCard = ({ team }) => {
4646
/>
4747
</div>
4848

49-
<Link to={`/taas/myteams/${team.id}`} styleName="title">
50-
{team.name}
51-
</Link>
49+
<div styleName="title-wrapper">
50+
<Link to={`/taas/myteams/${team.id}`} styleName="title">
51+
{team.name}
52+
</Link>
53+
</div>
5254

5355
<div styleName="data-items">
5456
<DataItem title="Start - End Date" icon={<IconCalendar />}>

src/routes/MyTeamsList/components/TeamCard/styles.module.scss

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,17 +6,25 @@
66
position: relative;
77
}
88

9+
.title-wrapper {
10+
box-sizing: border-box;
11+
padding-right: 24px;
12+
width: 100%;
13+
}
14+
915
.title {
1016
@include font-barlow;
1117
color: #219174;
1218
display: inline-block;
1319
font-size: 20px;
1420
font-weight: 600;
1521
line-height: 24px;
16-
overflow: hidden;
22+
margin-right: 40px;
1723
text-decoration: none;
1824
text-transform: uppercase;
25+
overflow: hidden;
1926
text-overflow: ellipsis;
27+
white-space: nowrap;
2028
max-width: 100%;
2129
}
2230

0 commit comments

Comments
 (0)