Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

Commit 41710bc

Browse files
authored
Merge pull request #457 from cagdas001/dev
Title/Subtitle Update in SkillListPopup & Progress card fixes
2 parents 254be39 + f4a2219 commit 41710bc

File tree

4 files changed

+12
-12
lines changed

4 files changed

+12
-12
lines changed

src/routes/CreateNewTeam/components/SearchContainer/index.jsx

+6-7
Original file line numberDiff line numberDiff line change
@@ -80,11 +80,10 @@ function SearchContainer({
8080
return <NoMatchingProfilesResultCard role={matchingRole} />;
8181
};
8282

83-
const getPercentage = useCallback(() => {
84-
if (searchState === "searching") return "26";
85-
if (matchingRole) return "53";
86-
return "84";
87-
}, [searchState, matchingRole]);
83+
const progressBarPercentage = useMemo(
84+
() => (searchState === "searching" ? 53 : 84),
85+
[searchState]
86+
);
8887

8988
return (
9089
<div styleName="page">
@@ -94,14 +93,14 @@ function SearchContainer({
9493
<Progress
9594
isDisabled={
9695
!buttonClickable ||
97-
searchState === "searching" ||
9896
(searchState === "done" && (!addedRoles || !addedRoles.length))
9997
}
98+
isSearching={searchState === "searching"}
10099
onClick={() => setAddAnotherOpen(true)}
101100
extraStyleName={progressStyle}
102101
buttonLabel="Continue"
103102
stages={stages}
104-
percentage={getPercentage()}
103+
percentage={progressBarPercentage}
105104
/>
106105
</div>
107106
<AddAnotherModal

src/routes/CreateNewTeam/components/SkillListPopup/index.jsx

+4-3
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,11 @@ function SkillListPopup({
2323
onClose,
2424
onContinueClick,
2525
}) {
26+
const title = page === "jd" ? "Identified Skills" : "Selected Skills";
2627
const subTitle =
2728
page === "jd"
28-
? `Topcoder has identified the following skills referenced in your job description. Select your the ${MAX_SELECTED_SKILLS} skills most important to be successful in the job. These skills will be weighted more heavily in matching.`
29-
: `You have chosen the following skills in your request. Please select your the ${MAX_SELECTED_SKILLS} skills most important to be successful in the job. These skills will be weighted more heavily in matching.`;
29+
? `Topcoder has identified the following skills referenced in your job description. Select the ${MAX_SELECTED_SKILLS} skills most important to be successful in the job. These skills will be weighted more heavily in matching.`
30+
: `You have chosen the following skills in your request. Please select the ${MAX_SELECTED_SKILLS} skills most important to be successful in the job. These skills will be weighted more heavily in matching.`;
3031
const skillsNotFoundTxt = "No skills are found in your Job Description";
3132

3233
const toggleSkill = useCallback(
@@ -62,7 +63,7 @@ function SkillListPopup({
6263
open={open}
6364
onClose={onClose}
6465
headerIcon={<IconSingleManAdd />}
65-
title="Identified Skills"
66+
title={title}
6667
subtitle={skills.length ? subTitle : skillsNotFoundTxt}
6768
isLoading={isLoading}
6869
loadingMessage={loadingTxt || "Loading..."}

src/routes/CreateNewTeam/components/SubmitContainer/index.jsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ function SubmitContainer({
163163
isDisabled={!buttonClickable}
164164
buttonLabel="Continue"
165165
stages={stages}
166-
percentage="98"
166+
percentage="84"
167167
/>
168168
</div>
169169
<AddAnotherModal

src/routes/CreateNewTeam/pages/CreateTaasPayment/index.jsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ const CreateTassPayment = () => {
160160
stages={stages}
161161
extraStyleName="role-selection final-step"
162162
disabled="true"
163-
percentage="98"
163+
percentage="97"
164164
/>
165165
</div>
166166
);

0 commit comments

Comments
 (0)