Avoid mutating redux state, set success and error titles in popup options, coding style fixes

Author: mbaghel

src/components/EmailPopup/index.jsx

@@ -26,24 +26,26 @@ function EmailPopup() {
   const submitEmail = () => {
     setIsLoading(true);
 
-    _.set(data, popupOptions.textDataField, textVal);
+    const postData = _.merge({}, data);
 
-    postEmail(data)
+    _.set(postData, popupOptions.textDataField, textVal);
+
+    postEmail(postData)
       .then(() => {
         setIsLoading(false);
         closeModal();
-        toastr.success("Email submitted successfully");
+        toastr.success(popupOptions.successTitle);
       })
       .catch((err) => {
         setIsLoading(false);
 
-        toastr.error("Email failed to send", err.message);
+        toastr.error(popupOptions.errorTitle, err.message);
       });
   };
 
   const button = (
     <Button
-      onClick={() => submitEmail()}
+      onClick={submitEmail}
       size="medium"
       isSubmit
       disabled={textVal.trim().length < 1 || isLoading}

src/utils/format.js

@@ -137,6 +137,8 @@ export const formatReportPopup = (teamName, memberHandle) => {
     }`,
     textPlaceholder: "Describe your issue",
     textDataField: "data.reportText",
+    successTitle: "Report submitted successfully",
+    errorTitle: "Report failed",
   };
 };
 
@@ -154,6 +156,8 @@ export const formatExtensionPopup = (teamName, memberHandle) => {
     }`,
     textPlaceholder: "Add any comments...",
     textDataField: "data.text",
+    successTitle: "Extension request submitted successfully",
+    errorTitle: "Extension request failed",
   };
 };
 
@@ -175,8 +179,8 @@ export const formatReportData = (teamName, teamId, memberHandle) => {
   };
 
   if (!!memberHandle) {
-    _.set(data, "template", "member-issue-report"),
-      _.set(data, "data.userHandle", memberHandle);
+    _.set(data, "template", "member-issue-report");
+    _.set(data, "data.userHandle", memberHandle);
   }
 
   return data;